-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
Refine cards UI #11192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine cards UI #11192
Conversation
1697110
to
6313b96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not manually tested.
And related to all those "link" pages: I think we are adding too many visualizations for our links (buttons, texts, etc.): I would prefer to use the same hover and styling effects for all links: breadcrumb, sidebar, buttons in title, buttons in app bar, buttons in card. Now some have a hover, some a hover with border, some have nothing, this is not consistent. |
ad6568d
to
1229dc7
Compare
Yep, this PR caused that - I've fixed it now. Thanks!
I can see that - I'm struggling to find other examples right now and definitely one to iterate on, but just this morning I noticed it after waking up - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new buttons and the hover-effect look good now! Thanks for adjusting that...
The console card (and the legacy card) have the correct height now. But the width of both cards is broken (twice the page screen width). This is broken in Jenkins 2.532 as well, so maybe unrelated to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label ready-for-merge
This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.
Thanks!
This PR refines the appearance of cards in Jenkins. It:
teaser
class, essentially for a when a card has too much content to show (e.g. too many tests, too many artefacts)Relates to jenkinsci/pipeline-graph-view-plugin#1006
Before

After

Testing done
Proposed changelog entries
Proposed changelog category
/label web-ui,rfe
Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge
:Maintainer checklist
upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).