[JENKINS-76192] Ignore NoSuchFileException in FilePath#unzip #11186
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-76192.
Issue initially found in jenkinsci/sonargraph-integration-plugin#31
It appears that during
FilePath#unzip
the file that was just unpacked cannot be found in the following calls, causingNoSuchFileException
to be thrown.The issue occurs in
com.hello2morrow.sonargraph.integration.jenkins.controller.CustomMetricTest#testSameReportDoesNotAddMetricId
It could only be reproduced on
ci.jenkins.io
on both, linux and windows agent. I was unable to reproduce it in my local environment.First I tried to add a retry-loop with a
Thread.sleep
as I suspected a slow filesystem being the cause but could not confirm this being the case. My checks show that the file is indeed present and there does not seem to be anything wrong with it. So ignoring the exception seemed to be the only remedy. My working theory is that it could be an issue of the environment.While I'm not a big fan of these kinds of workarounds, I think it will not cause any real harm here to ignore the expections.
Testing done
I would not know how to create a unit test that validates the behavior, however jenkinsci/sonargraph-integration-plugin#34 shows that the fix appears to be working.
Proposed changelog entries
NoSuchFileException
inFilePath#unzip
Proposed changelog category
/label bug
Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@jenkinsci/core-pr-reviewers
Before the changes are marked as
ready-for-merge
:Maintainer checklist
upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).