-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
Stream HTML console log #11177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Stream HTML console log #11177
Conversation
…arge-text-interface
This will avoid high churn of buffers when resetting the line buffer at the end of each line and processing long log lines.
Increase buffer sizes in ConsoleAnnotationOutputStream to avoid high churn of buffers when resetting at each end of a line.
Please take a moment and address the merge conflicts of your pull request. Thanks! |
…face' into stream-html-log # Conflicts: # bom/pom.xml # test/pom.xml
- Fix typo in documentation - use modern JavaScript (let/const/object spread) - use simpler type for header map - use descriptive variable in test helper Co-authored-by: Tim Jacomb <[email protected]>
Thanks for the feedback, Tim. I've addressed it in 831b743. |
Please take a moment and address the merge conflicts of your pull request. Thanks! |
if (isHtml()) | ||
return writeHtmlTo(start, new OutputStreamWriter(out, StandardCharsets.UTF_8)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a potentially incompatible change. Is there a need for it?
<!-- Faster incremental build https://github.com/jenkinsci/jenkins/pull/11071#issuecomment-3368149474 --> | ||
<test>hudson.console.ConsoleAnnotatorTest</test> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The initial purpose of this PR is obtaining an incremental version of Jenkins core for using in the workflow-api plugin.
Chain: stapler -> Jenkins core -> workflow-api -> pipeline-graph-view-plugin.
Once #11175 has landed, I can land #11071 and remove the commits from this PR.
Testing done
See updated tests for the
log/progressiveHtml
endpoint. Open console while build is in progress.Proposed changelog entries
Proposed changelog category
/label developer
Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
cc @timja @jglick
Before the changes are marked as
ready-for-merge
:Maintainer checklist
upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).