Skip to content

Conversation

das7pad
Copy link
Contributor

@das7pad das7pad commented Oct 7, 2025

The initial purpose of this PR is obtaining an incremental version of Jenkins core for using in the workflow-api plugin.

Chain: stapler -> Jenkins core -> workflow-api -> pipeline-graph-view-plugin.

Once #11175 has landed, I can land #11071 and remove the commits from this PR.

Testing done

See updated tests for the log/progressiveHtml endpoint. Open console while build is in progress.

Proposed changelog entries

  • Stream HTML console log

Proposed changelog category

/label developer

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

cc @timja @jglick

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@comment-ops-bot comment-ops-bot bot added the developer Changes which impact plugin developers label Oct 7, 2025
Copy link
Contributor

github-actions bot commented Oct 8, 2025

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Oct 8, 2025
das7pad and others added 2 commits October 8, 2025 22:04
…face' into stream-html-log

# Conflicts:
#	bom/pom.xml
#	test/pom.xml
- Fix typo in documentation
- use modern JavaScript (let/const/object spread)
- use simpler type for header map
- use descriptive variable in test helper

Co-authored-by: Tim Jacomb <[email protected]>
@github-actions github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Oct 8, 2025
@das7pad
Copy link
Contributor Author

das7pad commented Oct 8, 2025

Thanks for the feedback, Tim. I've addressed it in 831b743.

@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Oct 9, 2025
Copy link
Contributor

github-actions bot commented Oct 9, 2025

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Oct 9, 2025
@timja timja requested a review from jglick October 9, 2025 13:53
Comment on lines +227 to +228
if (isHtml())
return writeHtmlTo(start, new OutputStreamWriter(out, StandardCharsets.UTF_8));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a potentially incompatible change. Is there a need for it?

Comment on lines +56 to +57
<!-- Faster incremental build https://github.com/jenkinsci/jenkins/pull/11071#issuecomment-3368149474 -->
<test>hudson.console.ConsoleAnnotatorTest</test>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

developer Changes which impact plugin developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants