Skip to content

Conversation

MinuteHanD
Copy link

@MinuteHanD MinuteHanD commented Sep 12, 2025

Adds getCause() method to ChannelTermination that exports the cause field only when the exception has @ExportedBean annotation.
This allows the API to include detailed error information for exportable exceptions while maintaining backward compatibility.

See JENKINS-49217

Testing done

Added unit tests covering exportable exceptions, non-exportable exceptions, and null handling.

Proposed changelog entries

Export channel termination cause details when exception has @ExportedBean annotation

Proposed changelog category

/label bug

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @restricted or have @SInCE TODO Javadocs, as appropriate.
  • New deprecations are annotated with @deprecated(since = "TODO") or @deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

Copy link

welcome bot commented Sep 12, 2025

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

Copy link

I wasn't able to add the following labels: enhancement

Check that the label exists and is spelt right then try again.

@comment-ops-bot comment-ops-bot bot added the bug For changelog: Minor bug. Will be listed after features label Sep 12, 2025
@MinuteHanD MinuteHanD force-pushed the feature/JENKINS-49217-export-channel-termination-cause branch from 1aaa2c3 to 6976116 Compare September 12, 2025 20:59
@MinuteHanD MinuteHanD marked this pull request as ready for review September 13, 2025 04:16
@MinuteHanD MinuteHanD force-pushed the feature/JENKINS-49217-export-channel-termination-cause branch from d23df8a to 9d86210 Compare September 13, 2025 06:57
…dBean.[FIXES JENKINS-49217]

Add getCause() method to ChannelTermination that conditionally exports
the cause field when the exception has @ExportedBean annotation.

This allows the Jenkins API to include detailed error information
for channel termination causes that are designed to be exportable,
while maintaining backward compatibility for non-exportable exceptions.
@MinuteHanD MinuteHanD force-pushed the feature/JENKINS-49217-export-channel-termination-cause branch from 9d86210 to 0585c5c Compare September 13, 2025 09:24
@NotMyFault NotMyFault requested a review from a team September 14, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug For changelog: Minor bug. Will be listed after features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant