-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
Replaced deprecated methods with recommended alternatives #11018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
ccb210a
to
3f07014
Compare
fc741fe
to
8d5b003
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolve issues reported by the linter locally, build locally then push fix to this PR
eed0574
to
742f453
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
91c0b64
to
8d13c9c
Compare
15411dd
to
8331d31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modernizes deprecated API usage by replacing outdated methods with their recommended alternatives. The changes focus on improving code maintainability by migrating away from deprecated APIs that may be removed in future versions.
- Replaced deprecated
ANTLRException
withIllegalArgumentException
in exception handling documentation - Replaced deprecated
IOUtils.toString()
with modernInputStream.readAllBytes()
for stream processing
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
core/src/main/java/hudson/scheduler/CronTabList.java | Added deprecation warning comment about exception type change |
core/src/main/java/hudson/os/WindowsUtil.java | Replaced IOUtils.toString() with readAllBytes() and removed unused import |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
546239b
to
aedf1bb
Compare
…oString(input, Charset.defaultCharset())
0ca92a8
to
d631fec
Compare
ANTLRException
withIllegalArgumentException
as recommended by ANTLRException documentIOUtils.toString(final InputStream input)
with recommendedtoString(input, Charset.defaultCharset())
Testing done
N/A
Proposed changelog entries
N/A
Proposed changelog category
/label skip-changelog
Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
N/A
Before the changes are marked as
ready-for-merge
:Maintainer checklist
upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).