-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
[JENKINS-75990] Use the same styling for title bar mouse over effect #11016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/label web-ui |
|
Thanks for creating this PR! I think the colors and the border already look correct. What is missing: the height of the breadcrumb (the textual part) is not the same as the height of the buttons and the sidebar. Can this be adjusted as well? |
|
Hey, just on leave at the moment but I'll take a look at this. |
uhafner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks for the fix!
|
Do you have an idea (not in this PR) how we can add a hover effect for the Jenkins logo as well? The hover effect for this part of the breadcrumb is almost invisible right now. |
Sure, I can try adding a hover effect for the Jenkins logo in another PR. |
|
@janfaracik I have updated it. @uhafner, what do you think about the breadcrumb height? |
|
Well, for me it is a matter of symmetry. So I personally prefer the same height. It already looks weird that the height of the chevron overlay is different. But this is not a blocker for me. Jan is the designer, he probably knows better what to do... what think other people? |
|
@janfaracik, what are your thoughts? |
|
Apologies for taking so long to respond - could you rebase with |
@janfaracik I have updated it. Thank you. |
| pointer-events: all !important; | ||
| } | ||
|
|
||
| .dropdown-indicator { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
%breadcrumb-interactive-base {
@include mixins.item($border: false);
--item-background: transparent;
display: flex;
align-items: center;
justify-content: center;
height: 1.75rem;
}
& > a {
@extend %breadcrumb-interactive-base;
}
.dropdown-indicator {
@extend %breadcrumb-interactive-base;
padding: 0 0.3125rem;
}
& > a,
span {
position: relative;
font-size: var(--font-size-sm);
font-weight: var(--font-bold-weight);
margin: 0;
padding: 0.25rem 0.5rem;
color: inherit;
text-decoration: none;
text-wrap: nowrap;
flex-shrink: 0;
max-width: 25ch;
text-overflow: ellipsis;
white-space: nowrap;
}
// '/' separator between two items
&::before {
content: "/";
position: relative;
flex-shrink: 0;
color: color-mix(in sRGB, var(--text-color-secondary) 30%, transparent);
padding-left: 4px;
padding-right: 4px;
@media (prefers-contrast: more) {
color: var(--text-color);
}
}
}
}Thanks! Try this - couldn't make a clean suggestion through GitHub - I've changed Iines 28 to 79.
A few tweaks I've made:
@include mixins.itemsupports($border: false)to hide the border - so no need for thehover, active, ...conditions- Made the dropdown the same height as the breadcrumb item
- Fixed the mouse down state - it now pulses like other buttons
- Removed some unused variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janfaracik I have updated it. Thank you.
janfaracik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks!
|
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
|
Causes JENKINS-76299 - Jenkins 2.536 and later overlap text when viewing builds for jobs with long names @ridemountainpig could you investigate further and propose a fix? We'll choose the next LTS baseline by Dec 10, 2025 and I'd really like JENKINS-76299 to be fixed while still retaining the fix for JENKINS-75990. I've assigned that issue to you in Jira. If you're not able to investigate it and provide a fix, let me know and I'll unassign it from you. |
Got it, I will take a look at this. |
@MarkEWaite I've fixed it in #11334. |
Thanks very much! I've done some interactive testing of #11334 and confirmed it is fixed. Thanks again! |




Use the same styling for title bar mouse over effect.
See JENKINS-75990.
Testing done
Before

After

Proposed changelog entries
Proposed changelog category
/label web-ui
Proposed upgrade guidelines
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).