Skip to content

Conversation

@ridemountainpig
Copy link
Contributor

@ridemountainpig ridemountainpig commented Aug 27, 2025

Use the same styling for title bar mouse over effect.
See JENKINS-75990.

Testing done

Before
CleanShot 2025-08-27 at 14 54 13@2x

After
CleanShot 2025-08-27 at 14 59 14@2x

Proposed changelog entries

  • Use the same styling for title bar mouseover effect.

Proposed changelog category

/label web-ui

Proposed upgrade guidelines

  • Use the same styling for title bar mouse over effect

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@ridemountainpig
Copy link
Contributor Author

/label web-ui

@comment-ops-bot comment-ops-bot bot added the web-ui The PR includes WebUI changes which may need special expertise label Aug 27, 2025
@krisstern krisstern requested review from a team, janfaracik and timja August 27, 2025 12:03
@krisstern krisstern added rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted and removed rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Aug 27, 2025
@uhafner
Copy link
Member

uhafner commented Aug 27, 2025

Thanks for creating this PR! I think the colors and the border already look correct. What is missing: the height of the breadcrumb (the textual part) is not the same as the height of the buttons and the sidebar. Can this be adjusted as well?

@ridemountainpig
Copy link
Contributor Author

Thanks for creating this PR! I think the colors and the border already look correct. What is missing: the height of the breadcrumb (the textual part) is not the same as the height of the buttons and the sidebar. Can this be adjusted as well?

I’ve adjusted the breadcrumb height so it now matches the buttons and the sidebar. Thank you.

CleanShot 2025-08-28 at 00 06 18@2x

@janfaracik
Copy link
Member

Hey, just on leave at the moment but I'll take a look at this.

Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks for the fix!

@uhafner
Copy link
Member

uhafner commented Aug 27, 2025

Do you have an idea (not in this PR) how we can add a hover effect for the Jenkins logo as well? The hover effect for this part of the breadcrumb is almost invisible right now.

@ridemountainpig
Copy link
Contributor Author

Do you have an idea (not in this PR) how we can add a hover effect for the Jenkins logo as well? The hover effect for this part of the breadcrumb is almost invisible right now.

Sure, I can try adding a hover effect for the Jenkins logo in another PR.

@janfaracik
Copy link
Member

Thanks -

Not a fan of the increased height, I don't think that the breadcrumbs need to match the height of the buttons on the other side of the screen, seeing as breadcrumbs are just text vs icons.

Also, in regards to the Jenkins logo - would support decreasing the opacity further on hover, but I'm not sure how we could apply this background to it without it looking off. The reason for not having the background on the breadcrumbs in the first place was for consistency with the logo.


Not blocking - would be good to fix whilst in this space:

image

@ridemountainpig
Copy link
Contributor Author

image

@janfaracik I have updated it. @uhafner, what do you think about the breadcrumb height?
Arc 2025-09-02 21 34 03

@uhafner
Copy link
Member

uhafner commented Sep 2, 2025

Well, for me it is a matter of symmetry. So I personally prefer the same height. It already looks weird that the height of the chevron overlay is different.

But this is not a blocker for me. Jan is the designer, he probably knows better what to do... what think other people?

@ridemountainpig
Copy link
Contributor Author

@janfaracik, what are your thoughts?

@janfaracik
Copy link
Member

Apologies for taking so long to respond - could you rebase with master and I'll get back? Thanks :)

@ridemountainpig
Copy link
Contributor Author

Apologies for taking so long to respond - could you rebase with master and I'll get back? Thanks :)

@janfaracik I have updated it. Thank you.

pointer-events: all !important;
}

.dropdown-indicator {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%breadcrumb-interactive-base {
        @include mixins.item($border: false);

        --item-background: transparent;

        display: flex;
        align-items: center;
        justify-content: center;
        height: 1.75rem;
      }

      & > a {
        @extend %breadcrumb-interactive-base;
      }

      .dropdown-indicator {
        @extend %breadcrumb-interactive-base;

        padding: 0 0.3125rem;
      }

      & > a,
      span {
        position: relative;
        font-size: var(--font-size-sm);
        font-weight: var(--font-bold-weight);
        margin: 0;
        padding: 0.25rem 0.5rem;
        color: inherit;
        text-decoration: none;
        text-wrap: nowrap;
        flex-shrink: 0;
        max-width: 25ch;
        text-overflow: ellipsis;
        white-space: nowrap;
      }

      // '/' separator between two items
      &::before {
        content: "/";
        position: relative;
        flex-shrink: 0;
        color: color-mix(in sRGB, var(--text-color-secondary) 30%, transparent);
        padding-left: 4px;
        padding-right: 4px;

        @media (prefers-contrast: more) {
          color: var(--text-color);
        }
      }
    }
  }

Thanks! Try this - couldn't make a clean suggestion through GitHub - I've changed Iines 28 to 79.

A few tweaks I've made:

  • @include mixins.item supports ($border: false) to hide the border - so no need for the hover, active, ... conditions
  • Made the dropdown the same height as the breadcrumb item
  • Fixed the mouse down state - it now pulses like other buttons
  • Removed some unused variables

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janfaracik I have updated it. Thank you.

@timja timja requested a review from janfaracik October 26, 2025 21:53
Copy link
Member

@janfaracik janfaracik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@timja
Copy link
Member

timja commented Nov 4, 2025

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Nov 4, 2025
@timja timja merged commit 313c6ff into jenkinsci:master Nov 10, 2025
19 checks passed
@MarkEWaite
Copy link
Contributor

MarkEWaite commented Nov 20, 2025

Causes JENKINS-76299 - Jenkins 2.536 and later overlap text when viewing builds for jobs with long names

@ridemountainpig could you investigate further and propose a fix? We'll choose the next LTS baseline by Dec 10, 2025 and I'd really like JENKINS-76299 to be fixed while still retaining the fix for JENKINS-75990.

I've assigned that issue to you in Jira. If you're not able to investigate it and provide a fix, let me know and I'll unassign it from you.

@ridemountainpig
Copy link
Contributor Author

Causes JENKINS-76299 - Jenkins 2.536 and later overlap text when viewing builds for jobs with long names

@ridemountainpig could you investigate further and propose a fix? We'll choose the next LTS baseline by Dec 10, 2025 and I'd really like JENKINS-76299 to be fixed while still retaining the fix for JENKINS-75990.

I've assigned that issue to you in Jira. If you're not able to investigate it and provide a fix, let me know and I'll unassign it from you.

Got it, I will take a look at this.

@ridemountainpig
Copy link
Contributor Author

Causes JENKINS-76299 - Jenkins 2.536 and later overlap text when viewing builds for jobs with long names

@ridemountainpig could you investigate further and propose a fix? We'll choose the next LTS baseline by Dec 10, 2025 and I'd really like JENKINS-76299 to be fixed while still retaining the fix for JENKINS-75990.

I've assigned that issue to you in Jira. If you're not able to investigate it and provide a fix, let me know and I'll unassign it from you.

@MarkEWaite I've fixed it in #11334.

@MarkEWaite
Copy link
Contributor

@MarkEWaite I've fixed it in #11334.

Thanks very much! I've done some interactive testing of #11334 and confirmed it is fixed. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants