-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(linux): add support on Linux for JDK 25 preview in Docker build configurations #2072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 10 commits
c6924e3
b042763
2215a9c
735df02
8068078
a03a210
df134dd
ad1dadf
9167247
5328f9b
e047079
e259f04
5fca1b4
a79bd69
3f160a8
146242f
8441f07
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,7 @@ ARG ALPINE_TAG=3.22.1 | |
| FROM alpine:"${ALPINE_TAG}" AS jre-build | ||
|
|
||
| ARG JAVA_VERSION=17.0.16_8 | ||
| ARG JLINK_MODULES_DEFAULT=java.base,java.logging,java.xml,java.management,java.net.http,jdk.crypto.ec,jdk.zipfs,jdk.unsupported,jdk.charsets | ||
|
|
||
| SHELL ["/bin/ash", "-o", "pipefail", "-c"] | ||
|
|
||
|
|
@@ -22,15 +23,17 @@ ENV PATH="/opt/jdk-${JAVA_VERSION}/bin:${PATH}" | |
| # for now we include the full module path to maintain compatibility | ||
| # while still saving space (approx 200mb from the full distribution) | ||
| RUN case "$(jlink --version 2>&1)" in \ | ||
| "17."*) set -- "--compress=2" ;; \ | ||
| "17."*) set -- "--compress=2" "--add-modules" "ALL-MODULE-PATH" ;; \ | ||
| # the compression argument is different for JDK21 | ||
| "21."*) set -- "--compress=zip-6" ;; \ | ||
| "21."*) set -- "--compress=zip-6" "--add-modules" "ALL-MODULE-PATH" ;; \ | ||
| # the compression argument is different for JDK25 (early access) | ||
| "25"*) mod_list="${JLINK_MODULES:-$JLINK_MODULES_DEFAULT}"; \ | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Question: what's the purpose of having two variables for jlink modules?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The goal was to have |
||
| set -- "--compress=zip-6" --add-modules "$mod_list" ;; \ | ||
| *) echo "ERROR: unmanaged jlink version pattern" && exit 1 ;; \ | ||
| esac; \ | ||
| jlink \ | ||
| --strip-java-debug-attributes \ | ||
| "$1" \ | ||
| --add-modules ALL-MODULE-PATH \ | ||
| "$@" \ | ||
| --no-man-pages \ | ||
| --no-header-files \ | ||
| --output /javaruntime | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.