[JENKINS-75157] Bitbucket client fail to retrieve resource with HTTP 404 for bitbucket server

[nfalco79]

Remove the HttpHost parameter when calling in Apache client as it seems to cause a 404 error in the response while in previous version the call worked.

[KalleOlaviNiemitalo]

@nfalco79, I was looking at the exception stack traces in https://community.jenkins.io/t/file-not-found-exception-updating-bitbucket-source-plugin-to-latest-version-933-3-0/25724 and comparing to the templating engine implementation in https://github.com/jenkinsci/templating-engine-plugin/blob/2.5.3/src/main/groovy/org/boozallen/plugins/jte/util/FileSystemWrapper.groovy and to https://github.com/jenkinsci/bitbucket-branch-source-plugin/blob/933.3.0/src/main/java/com/cloudbees/jenkins/plugins/bitbucket/impl/client/AbstractBitbucketApi.java. I think what happens is:

• doRequest gets HTTP status 404 from the server and this is correct because the file does not exist in the repository.
• doRequest recognizes HttpStatus.SC_NOT_FOUND and throws FileNotFoundException.
• doRequest catches this FileNotFoundException as IOException and throws another IOException that has the FileNotFoundException as its cause.
• The JTE FileSystemWrapper does not catch this IOException because it only expects FileNotFoundException.

So the fix should be to make doRequest propagate the FileNotFoundException as is, rather than wrapped in IOException.

I assume this is reproducible with Bitbucket Cloud too, as long as JTE is used and the file does not exist in the repo.

[KalleOlaviNiemitalo]

(I'm not working on the doRequest FileNotFoundException fix myself.)

[KalleOlaviNiemitalo]

In addition, BitbucketSCMFile.type() could be changed to query the server if the BitbucketSCMFile was created by calling SCMFile.child(String path) and the existence has not been verified yet; see how github-branch-source-plugin does it. This would make SCMFile.exists() return false to the template engine, which then would not call BitbucketSCMFile.content.