Skip to content

feat: supplement part of footer links correction#337

Open
biru-codeastromer wants to merge 5 commits intojenkins-infra:mainfrom
biru-codeastromer:footer-links-correction
Open

feat: supplement part of footer links correction#337
biru-codeastromer wants to merge 5 commits intojenkins-infra:mainfrom
biru-codeastromer:footer-links-correction

Conversation

@biru-codeastromer
Copy link
Copy Markdown
Contributor

Fix #336
Complement part for footer links correction

Main context :

Fix #336

I have corrected the logic to handle docs.jenkins.io

N.B = Logic for handling multiples versions will be done later in july during antora works along with the navbar PR

@krisstern
Copy link
Copy Markdown
Member

@biru-codeastromer same comments apply here as well: #318 (comment)

@krisstern
Copy link
Copy Markdown
Member

Hi @biru-codeastromer you have not followed up on this PR at all since about 2 months ago

@biru-codeastromer
Copy link
Copy Markdown
Contributor Author

Hi @biru-codeastromer you have not followed up on this PR at all since about 2 months ago

Hi Kris,
The footer and top navbar follow the same logic you mentioned last week, so I haven’t made any changes there. As discussed, we’ll include our new logic and approach in the same PR.

@biru-codeastromer
Copy link
Copy Markdown
Contributor Author

Hi @biru-codeastromer you have not followed up on this PR at all since about 2 months ago

Done @krisstern I have both the PR in jenkins-io components as well and as well here in navbar both repo PR have been updated with new txt file approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correct footer links

2 participants