Refactor: Moved repeated inline styles in contributor details to CSS classes#577
Open
Rohan-Ver-ma wants to merge 1 commit intojenkins-infra:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up repeated inline styles in the contributor details template and moves them into the existing stylesheet.
I noticed we were repeating the same link-reset styles and circle image styles in a few places inside the template. It worked, but it made the JSX noisier and harder to maintain. This change keeps the exact same behavior and visuals, just with cleaner structure.
What changed:
Refactoring Summary
contributor-details-link-plain
contributor-details-link-reset
(e.g., object-fit: cover, border-radius: 50%) with:
contributor-details-circle-image
contributor-details.css
contributor-details.jsx
Checklist