Skip to content

Fix transcode trickplay resume #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FractalBoy wants to merge 3 commits into
base: master
Choose a base branch
from
+15 −3
Open

Fix transcode trickplay resume #793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
101d988
Fix resuming from trickplay with transcode
FractalBoy Mar 20, 2026
b6a5731
Update What's New
FractalBoy Mar 20, 2026
0caf23c
Fix trickplay bar cleanup
FractalBoy Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions components/video/VideoPlayerView.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1597,6 +1597,14 @@ function onKeyEvent(key as string, press as boolean) as boolean
return false
end if

if (key = KeyCode.OK or key = KeyCode.PLAY) and m.top.trickPlayBar.visible and m.isTranscoded
if m.top.state = "paused"
Copy link
Member

@1hitsong 1hitsong Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if m.top.state = "paused"
if isStringEqual(m.top.state, MediaPlaybackState.PAUSED)

m.top.control = VideoControl.RESUME
m.top.trickPlayBar.visible = false
return true
end if
end if

' Disable OSD for intro videos
if not m.LoadMetaDataTask.isIntro
if key = KeyCode.PLAY and not m.top.trickPlayBar.visible
Expand Down
10 changes: 7 additions & 3 deletions source/static/whatsNew/3.1.8.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
},
{
"description": "Fix subtitle background opacity affecting text",
"author": "gabeluci"
},
"author": "gabeluci"
},
{
"description": "Prevent subtitles from getting too close to the top or bottom of the screen",
"author": "gabeluci"
Expand All @@ -30,5 +30,9 @@
{
"description": "Add setting to select how many items are loaded together on library screens",
"author": "brianpardy"
},
{
"description": "Fix resuming from trickplay on transcoded videos",
"author": "FractalBoy"
}
]
]