fixes #180

BinarySerializer.Test/Issues/Issue180/Issue180Tests.cs

@@ -0,0 +1,35 @@
+using System;
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+namespace BinarySerialization.Test.Issues.Issue180
+{
+    [TestClass]
+    public class Issue180Tests : TestBase
+    {
+        public class BitFieldsPrecededByByte
+        {
+            [FieldOrder(0)]
+            public byte First;
+
+            [FieldOrder(1)]
+            [FieldBitLength(7)]
+            public byte SevenBits;
+
+            [FieldOrder(2)]
+            [FieldBitLength(1)]
+            public byte OneBit;
+        }
+
+        [TestMethod]
+        public void TestOutOfMemory()
+        {
+            for (int i = 0; i < 7; i++)
+            {
+                Console.WriteLine($"Trying to deserialize array of partial {nameof(BitFieldsPrecededByByte)} with array size {i}");
+                var serialized = new byte[i];
+                // This call will never return and consumes all available memory
+                var _ = Deserialize<BitFieldsPrecededByByte[]>(serialized);
+            }
+        }
+    }
+}

BinarySerializer/BinarySerializer.csproj

@@ -4,14 +4,14 @@
     <Description>A declarative serialization framework for controlling formatting of data using field bindings.</Description>
     <AssemblyName>BinarySerializer</AssemblyName>
     <PackageTags>Serialization;Serializer;Binary;Format;Protocol</PackageTags>
-    <PackageReleaseNotes>Additional comparison operator support in conditional serialization</PackageReleaseNotes>
+    <PackageReleaseNotes>Bug fix for end-of-stream during collection deserialization</PackageReleaseNotes>
     <PackageProjectUrl>https://github.com/jefffhaynes/BinarySerializer</PackageProjectUrl>
     <PackageLicenseUrl></PackageLicenseUrl>
     <RepositoryType>git</RepositoryType>
     <RepositoryUrl>https://github.com/jefffhaynes/BinarySerializer</RepositoryUrl>
-    <AssemblyVersion>8.6.2</AssemblyVersion>
-    <FileVersion>8.6.2</FileVersion>
-    <Version>8.6.2</Version>
+    <AssemblyVersion>8.6.2.1</AssemblyVersion>
+    <FileVersion>8.6.2.1</FileVersion>
+    <Version>8.6.2.1</Version>
     <GeneratePackageOnBuild>True</GeneratePackageOnBuild>
     <Authors>Jeff Haynes</Authors>
     <Company />

BinarySerializer/Graph/ValueGraph/CollectionValueNode.cs

@@ -140,6 +140,11 @@ internal override async Task DeserializeOverrideAsync(BoundedStream stream, Even
                         await child.DeserializeAsync(childStream, eventShuttle, cancellationToken)
                             .ConfigureAwait(false);
 
+                        if (child.Value == null)
+                        {
+                            break;
+                        }
+
                         if (IsTerminated(child, itemTerminationValue))
                         {
                             ProcessLastItem(streamResetter, child);