Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add log in plugin autoloader #3020

Open
wants to merge 1 commit into
base: alpha
Choose a base branch
from
Open

Conversation

pifou25
Copy link
Contributor

@pifou25 pifou25 commented Jan 27, 2025

Description

add log in case of plugin error via the plugin autoloader, this is a great help for plugin developers :)

Suggested changelog entry

add log in case of plugin error via the plugin autoloader

Related issues/external references

Fixes #3017

Types of changes

  • Bug fix (non-breaking change which fixes)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

@Mips2648
Copy link
Collaborator

Why do you log exception in "core"? this is weird... who will ever thought about checking this log?

@pifou25
Copy link
Contributor Author

pifou25 commented Jan 30, 2025

Not sure where to put this log, and 'core' is the default for log path

public static function getPathToLog($_log = 'core') {

what else do you suggest ? 'plugin' could be better ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] PHP Parse error dans *pluginid*/plugin_info/install.php n'est pas envoyé vers http.error
8 participants