Kamwar/lesson 13 #675
Open
Kamwar/lesson 13 #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I corrected errors and try to join two commits
stickler-ci
reviewed
Jul 18, 2018
|
|
||
| def distance(point1, point2): | ||
| return math.sqrt((point1.x - point2.x) ** 2 | ||
| + (point1.y - point2.y) ** 2) |
Contributor
There was a problem hiding this comment.
W503 line break before binary operator
| print("the Point doesn't lay in or on the boundary of the circle.") | ||
|
|
||
| if rect_in_circle(circle, rectangle): | ||
| print("the Rectangle lies entirely in or on the boundary of the circle.") |
Contributor
There was a problem hiding this comment.
E501 line too long (81 > 79 characters)
| if rect_in_circle(circle, rectangle): | ||
| print("the Rectangle lies entirely in or on the boundary of the circle.") | ||
| else: | ||
| print("the Rectangle doesn't lay entirely in or on the boundary of the circle.") |
Contributor
There was a problem hiding this comment.
E501 line too long (88 > 79 characters)
| def create_dictionary(object): | ||
| new_dictionary = object.__dict__ | ||
| for i in new_dictionary.keys(): | ||
| if isinstance(new_dictionary[i],int): |
Contributor
There was a problem hiding this comment.
E231 missing whitespace after ','
| for i in new_dictionary.keys(): | ||
| if isinstance(new_dictionary[i],int): | ||
| print("key=", i, "value=", new_dictionary[i]) | ||
| elif isinstance(new_dictionary[i],float): |
Contributor
There was a problem hiding this comment.
E231 missing whitespace after ','
|
|
||
|
|
||
| def main(): | ||
| auto = Car("fiat", "white", 1/2) |
Contributor
There was a problem hiding this comment.
E226 missing whitespace around arithmetic operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kamwar Pleas check