Octree and Barnes Hut Implementation #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… segmentation fault in testing
…on and makefile configuration
…t, but need more coverage
…ed an envOctree member to the Grav Environment class; added some tests
…s-hut algo walking down the tree
…aml issue then can ake PR
…floats from doubles; implemented work with Adam's config stuff
…ile; added download of bc in coverage workflow
Adam-Boesky
previously approved these changes
Jan 6, 2024
src/environment.cpp
Outdated
|
|
||
| // Get the extreme coordinate locations | ||
| std::array<float, 2> extremeXCoords = {0, 0}; |
There was a problem hiding this comment.
shouldn't be zero here. should just be min/max
|
|
||
| // Calculate the forces | ||
| std::vector<std::array<float, 3>> forces(nParticles); // Vector to hold the forces | ||
| float theta = 0.5; |
| envOctree.updateCoords(extremeXCoords, extremeYCoords, extremeZCoords); | ||
|
|
||
| // Build the Octree | ||
| envOctree.build(particlePtrs); |
| if (internal) { | ||
|
|
||
| // Midpoints of coordinates | ||
| float mX = (xCoords[0] + xCoords[1]) / 2.; |
There was a problem hiding this comment.
i like .0 but i guess this is fine
| Octree<T>* child5; | ||
| Octree<T>* child6; | ||
| Octree<T>* child7; | ||
| std::shared_ptr<Octree<T>> child0; |
There was a problem hiding this comment.
do u think u could add like comments for each of the children that just say which octants they refer to? Might be helpful for understanding the logic in octree.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be a little too sick, honestly!