New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: FastWriter missing characters on buffer limit #115

Merged

jdereg merged 2 commits into jdereg:master from ozhelezniak-talend:ozhelezniak/fix_fastwriter_buffer_limit_values

Mar 24, 2025

+39 −0

Contributor

ozhelezniak-talend commented Mar 17, 2025 •

edited

Loading

The test should illustrate the problem.

Character 'T' was missed, because before flush we didn't update the length of the buffer
The first line that equals to the buffer size is ignored because flush didn't happen

ozhelezniak-talend added 2 commits

March 17, 2025 13:49


          fix: FastWriter missing characters on buffer limit

ed5e89d


          fix: FastWriter don't flush in case if exceed the limit

0c897ba

Contributor Author

ozhelezniak-talend commented Mar 17, 2025

Hello @jdereg
Could you review PR?

jdereg merged commit b638f76 into jdereg:master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet