feat: support etcd auth in etcd client via environment variables.#1175
Open
JimHsiung wants to merge 1 commit intojd-opensource:mainfrom
Open
feat: support etcd auth in etcd client via environment variables.#1175JimHsiung wants to merge 1 commit intojd-opensource:mainfrom
JimHsiung wants to merge 1 commit intojd-opensource:mainfrom
Conversation
JimHsiung
requested review from
DongheJin,
RobbieLeung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for Etcd authentication by adding an overloaded constructor to the EtcdClient class and utilizing environment variables for credentials. The changes also include a new utility function for optional environment variable retrieval. I have reviewed the code and identified two style guide violations regarding class inheritance and constructor explicitness that should be addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.