when debug flag set, print stack trace to console #25
Conversation
| @@ -29,6 +29,9 @@ var Restore = function(options) { | |||
| d.add(response); | |||
|
|
|||
| d.on('error', function(error) { | |||
| if (self._allow.debug) { | |||
| console.log('error: ', error, error.stack); | |||
There was a problem hiding this comment.
As it's reasonable to assume whoever uses the debug flag also uses a modern browser, you can actually throw an error here using error(message). See https://developer.mozilla.org/en-US/docs/Tools/Web_Console?redirectlocale=en-US&redirectslug=Using_the_Web_Console#Error_messages
There was a problem hiding this comment.
Could you change this to use process.env.DEBUG as the flag, please? We already support that option and I don't think we should add a new config option.
|
ping @jcoglan |
|
@silverbucket Did you see my line note above? I'm also not sure how the web console is relevant here. Is there a bridge between Node and the browser I'm not familiar with? |
Uhm, no idea how that brain fart happened! Was probably in the middle of commenting on remoteStorage(.js) issues left and right and somehow didn't realize what I was looking at. :) |
I've got myself into a bit of a mess with the original restore for I was using to add features/fix things. So, to make things simpler, I've made a new fork and will manually import my changes one at a time of separate branches and submit them to you.