Added the default_member_permissions parameter to adding application commands #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchristgit
requested changes
Jul 16, 2023
Owner
jchristgit
left a comment
jchristgit
left a comment
There was a problem hiding this comment.
Thank you for the pull request!
Two small comments, apart from that it's good to merge 🙂
Comment on lines
+272
to
+281
| @doc """ | ||
| An optional callback that returns a bitset for the required default permissions to run this command. | ||
| Example callback that requires that the user has the permission to ban members to be able to see and execute this command | ||
| ```elixir | ||
| def default_member_permissions, do: | ||
| Nostrum.Permission.to_bitset([:ban_members]) | ||
| ``` | ||
| """ |
Owner
There was a problem hiding this comment.
Let's dedent this by two spaces so it matches the rest of the module
Suggested change
| @doc """ | |
| An optional callback that returns a bitset for the required default permissions to run this command. | |
| Example callback that requires that the user has the permission to ban members to be able to see and execute this command | |
| ```elixir | |
| def default_member_permissions, do: | |
| Nostrum.Permission.to_bitset([:ban_members]) | |
| ``` | |
| """ | |
| @doc """ | |
| An optional callback that returns a bitset for the required default permissions to run this command. | |
| Example callback that requires that the user has the permission to ban members to be able to see and execute this command | |
| ```elixir | |
| def default_member_permissions, do: | |
| Nostrum.Permission.to_bitset([:ban_members]) |
"""
Contributor
Author
There was a problem hiding this comment.
I'll need a bit more time to do your recommended changes for personal reasons, but it's noted!
Owner
There was a problem hiding this comment.
No rush 🙂 If I can help out let me know!
Owner
Contributor
Author
|
I think these doesn't really need to be any integration, since the other PR supports what I do anyway |
to string as perdiscord documentation
jchristgit
approved these changes
Feb 6, 2025
Owner
|
Thank you for the PR, and sorry for the long wait here. I applied it in master. Have a great weekend! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since changing specific application command permissions is impossible with regular bot tokens anyway, at least we can set the default required permissions to run a command on add.