Skip to content

Handle ECONNABORTED and avoid joining the current thread #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle ECONNABORTED and avoid joining the current thread #323

wants to merge 1 commit into from

Conversation

avivbrg
Copy link

@avivbrg avivbrg commented Aug 5, 2025

In windows the socket might also be terminated with errno.ECONNABORTED, and since disconnect can be called from the message thread we need to avoid join in that case

herg
herg approved these changes Sep 4, 2025
View reviewed changes
Copy link

@herg herg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're also seeing a similar issue, cc @jxyz. would be great to get this fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@herg herg herg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@avivbrg @herg