Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BVH4_CPU traversal #118

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Fix BVH4_CPU traversal #118

merged 1 commit into from
Feb 20, 2025

Conversation

wuyakuma
Copy link
Contributor

The old code somehow fails to retrieve the correct lane data, leading to stack corruption with incorrect node indices, especially when optimization flags are enabled.

Not quite sure why, but these changes are currently working for me...

@wuyakuma
Copy link
Contributor Author

The BVH8/CWBVH & ALT_SOA doesn't have NEON implementation yet (BVH_USEAVX Marco in TestPrimaryRays()), so still have the Validation error

@jbikker
Copy link
Owner

jbikker commented Feb 20, 2025

"Not quite sure why" is a bit scary, but I'll merge the changes. ;) Thanks!

@jbikker jbikker merged commit b890fc6 into jbikker:dev Feb 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants