Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Omit tests directory from code coverage #735

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Fix: Omit tests directory from code coverage #735

Changes from 7 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1f5c91f
Fix: Omit tests directory from code coverage
Feb 28, 2024
c9fedb3
Add verbose for pytest command
Feb 28, 2024
3879b00
Fix: Omit tests directory from code coverage
Feb 28, 2024
802223a
Fix: Omit tests directory from pytest via command
Feb 28, 2024
f786c50
Fix: Omit tests directory from pytest via command
Feb 28, 2024
c015442
Fix: Omit tests directory from coverage
Feb 28, 2024
526df6f
Fix: Omit tests directory from mypy
Feb 28, 2024
774a8d8
Get code coverage report on the basis of flag management
sauravsharma1998 Feb 29, 2024
5bbbfd1
Get code coverage report on the basis of flag management
sauravsharma1998 Feb 29, 2024
40c7c2c
codecov.yml removed from project root and updated it in .github
sauravsharma1998 Feb 29, 2024
06adbb5
Upload mypy report to smokeshow
sauravsharma1998 Mar 1, 2024
ca099d0
Skip mypy report for codecov.io
sauravsharma1998 Mar 1, 2024
80b5d84
Fix: Upload mypy report to smokeshow
sauravsharma1998 Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,13 @@ hiredis = redis[hiredis]>=4.0.2

[coverage:run]
omit =
tests/*,
*/tests/*

[coverage:report]
precision = 1
skip_covered = true
omit =
*/tests/*

[tox:tox]
minversion = 3.15.0
Expand Down Expand Up @@ -80,18 +82,18 @@ REDIS =
[testenv]
passenv = CI, GITHUB*
commands =
{envpython} -m pytest --cov-report= --ds=settings.sqlite {posargs}
{envpython} -m pytest --cov-append --cov-report= --ds=settings.sqlite_herd {posargs}
{envpython} -m pytest --cov-append --cov-report= --ds=settings.sqlite_json {posargs}
{envpython} -m pytest --cov-append --cov-report= --ds=settings.sqlite_lz4 {posargs}
{envpython} -m pytest --cov-append --cov-report= --ds=settings.sqlite_msgpack {posargs}
{envpython} -m pytest --cov-append --cov-report= --ds=settings.sqlite_sentinel {posargs}
{envpython} -m pytest --cov-append --cov-report= --ds=settings.sqlite_sentinel_opts {posargs}
{envpython} -m pytest --cov-append --cov-report= --ds=settings.sqlite_sharding {posargs}
{envpython} -m pytest --cov-append --cov-report= --ds=settings.sqlite_usock {posargs}
{envpython} -m pytest --cov-append --cov-report= --ds=settings.sqlite_zlib {posargs}
{envpython} -m pytest --cov-append --cov-report= --ds=settings.sqlite_zstd {posargs}
{envpython} -m pytest --cov-append --cov-report= --ds=settings.sqlite_gzip {posargs}
{envpython} -m pytest -vv --ignore=tests/* --cov-report= --ds=settings.sqlite {posargs}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need these ignores?

{envpython} -m pytest -vv --ignore=tests/* --cov-append --cov-report= --ds=settings.sqlite_herd {posargs}
{envpython} -m pytest -vv --ignore=tests/* --cov-append --cov-report= --ds=settings.sqlite_json {posargs}
{envpython} -m pytest -vv --ignore=tests/* --cov-append --cov-report= --ds=settings.sqlite_lz4 {posargs}
{envpython} -m pytest -vv --ignore=tests/* --cov-append --cov-report= --ds=settings.sqlite_msgpack {posargs}
{envpython} -m pytest -vv --ignore=tests/* --cov-append --cov-report= --ds=settings.sqlite_sentinel {posargs}
{envpython} -m pytest -vv --ignore=tests/* --cov-append --cov-report= --ds=settings.sqlite_sentinel_opts {posargs}
{envpython} -m pytest -vv --ignore=tests/* --cov-append --cov-report= --ds=settings.sqlite_sharding {posargs}
{envpython} -m pytest -vv --ignore=tests/* --cov-append --cov-report= --ds=settings.sqlite_usock {posargs}
{envpython} -m pytest -vv --ignore=tests/* --cov-append --cov-report= --ds=settings.sqlite_zlib {posargs}
{envpython} -m pytest -vv --ignore=tests/* --cov-append --cov-report= --ds=settings.sqlite_zstd {posargs}
{envpython} -m pytest -vv --ignore=tests/* --cov-append --cov-report= --ds=settings.sqlite_gzip {posargs}
{envpython} -m coverage report
{envpython} -m coverage xml

Expand All @@ -115,7 +117,7 @@ envdir={toxworkdir}/lint
commands =
black: black --target-version py36 {posargs:--check --diff} setup.py django_redis/ tests/
ruff: ruff {posargs:check --show-fixes} django_redis/ tests/
mypy: mypy {posargs:--cobertura-xml-report .} django_redis tests
mypy: mypy {posargs:--cobertura-xml-report .} django_redis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please restore this, as also tests should be checked for typing errors so that we can notice breaking changes

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure @WisdomPill ! This was just experimental. Any suggestions to avoid tests directory from coverage report?

deps =
black
django-stubs
Expand Down
Loading