Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added types to DefaultClient #696

Merged
merged 8 commits into from
Nov 5, 2023

Conversation

WisdomPill
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #696 (2850090) into master (4b6dd5b) will increase coverage by 0.6%.
The diff coverage is 71.3%.

@@           Coverage Diff            @@
##           master    #696     +/-   ##
========================================
+ Coverage    60.6%   61.1%   +0.6%     
========================================
  Files          41      41             
  Lines        2608    2637     +29     
  Branches       69     142     +73     
========================================
+ Hits         1578    1611     +33     
+ Misses       1017    1013      -4     
  Partials       13      13             
Flag Coverage Δ
mypy 37.7% <46.6%> (+2.5%) ⬆️
tests 88.9% <90.7%> (-<0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
django_redis/pool.py 79.5% <100.0%> (ø)
django_redis/client/default.py 94.6% <97.9%> (+3.9%) ⬆️
tests/test_backend.py 15.1% <11.2%> (+0.2%) ⬆️
django_redis/client/sharded.py 81.7% <14.3%> (-3.9%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@WisdomPill WisdomPill merged commit 8014ce4 into jazzband:master Nov 5, 2023
23 of 24 checks passed
@WisdomPill WisdomPill deleted the redis_type_hints branch November 5, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant