Skip to content

scratch: CI race repro (do not merge) - #5

Closed
jayleaton wants to merge 3 commits into
mainfrom
scratch/ci-race
Closed

jayleaton wants to merge 3 commits into
mainfrom
scratch/ci-race

Conversation

@jayleaton

Copy link
Copy Markdown
Owner

Scratch PR to reproduce the draft/ready concurrency race. Will be closed.

@jayleaton
jayleaton marked this pull request as ready for review October 22, 2026 07:10
@jayleaton
jayleaton marked this pull request as draft October 22, 2026 07:11
@jayleaton
jayleaton marked this pull request as ready for review October 22, 2026 07:11
@jayleaton
jayleaton marked this pull request as draft October 22, 2026 07:13
@jayleaton
jayleaton marked this pull request as ready for review October 22, 2026 07:13
@jayleaton
jayleaton marked this pull request as draft October 22, 2026 07:14
@jayleaton
jayleaton marked this pull request as ready for review October 22, 2026 07:14
A force-push to a draft PR followed by "ready for review" a second later
started two runs in one concurrency group; when the draft run arrived
last it cancelled the real run, and its skipped ci-ok then counted as
the passing required check for the head SHA.

Draft and real runs now use separate concurrency groups, only PR runs
cancel superseded runs, and jobs in draft runs are renamed
"<job> (draft, not run)" so they never report as ci-ok.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jayleaton
jayleaton marked this pull request as draft October 22, 2026 07:17
@jayleaton
jayleaton marked this pull request as ready for review October 22, 2026 07:17
@jayleaton
jayleaton marked this pull request as draft October 22, 2026 07:18
@jayleaton
jayleaton marked this pull request as ready for review October 22, 2026 07:18
@jayleaton
jayleaton marked this pull request as draft October 22, 2026 07:19
@jayleaton
jayleaton marked this pull request as ready for review October 22, 2026 07:19
@jayleaton
jayleaton marked this pull request as draft October 22, 2026 07:21
@jayleaton
jayleaton marked this pull request as ready for review October 22, 2026 07:21
…revious head

When a push and "ready for review" land together, GitHub can attach the
ready_for_review run to the old head, leaving the new SHA with only the
skipped draft run and no ci-ok. A small draft job now checks the live
PR state: if the PR is ready and no other CI run covers this SHA, the
run does the real checks. ci-ok always runs and reports as
"ci (draft, not run)" in runs that stayed drafts, which also replaces
the job renames whose expressions showed raw on skipped jobs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jayleaton
jayleaton marked this pull request as draft October 22, 2026 07:24
@jayleaton
jayleaton marked this pull request as ready for review October 22, 2026 07:24
@jayleaton
jayleaton marked this pull request as draft October 22, 2026 07:25
@jayleaton
jayleaton marked this pull request as ready for review October 22, 2026 07:25
@jayleaton
jayleaton marked this pull request as draft October 22, 2026 07:27
@jayleaton
jayleaton marked this pull request as ready for review October 22, 2026 07:27
@jayleaton
jayleaton marked this pull request as draft October 22, 2026 07:28
@jayleaton
jayleaton marked this pull request as ready for review October 22, 2026 07:28
@jayleaton
jayleaton marked this pull request as draft October 22, 2026 07:30
@jayleaton
jayleaton marked this pull request as ready for review October 22, 2026 07:30
@jayleaton
jayleaton marked this pull request as draft October 22, 2026 07:34
@jayleaton
jayleaton marked this pull request as ready for review October 22, 2026 07:35
@jayleaton

Copy link
Copy Markdown
Owner Author

Scratch repro for the CI concurrency fix; closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant