Reimplement weakref_lru_cache on top of a custom hash map type. #35003
+1,930
−269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplement weakref_lru_cache on top of a custom hash map type.
The existing weakref_lru_cache has a number of concurrency problems that are unearthed by tsan and the tests added in this PR, but the key problem that made me decide that the existing approach does not work is the following:
tp_traverseGC traversal handler must hold the GIL (or, at least, the Python threads are all in a stopped state because Python GC is stop-the-world, which is much the same as holding the GIL), but would need to acquire mu_ to traverse the std::unordered_map. And since we are in the middle of GC, we cannot release the GIL. So there is no valid lock ordering possible.This PR takes a different approach: