Explicitly make out a jax.Array before converting it in lax_numpy.array.
#28966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_762322412
branch
4 times, most recently
from
6d1bad3 to
611a0fe
Compare
…y.array`. This allows avoiding an unnecessary copy in `lax_internal._convert_element_type` when the original `dtype` is the same as the output `dtype` (the fast path does an instance check, which fails on `np.ndarray`s). PiperOrigin-RevId: 762322412
copybara-service
bot
force-pushed
the
test_762322412
branch
from
611a0fe to
2a253e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly make
outajax.Arraybefore converting it inlax_numpy.array.This allows avoiding an unnecessary copy in
lax_internal._convert_element_typewhen the originaldtypeis the same asthe output
dtype(the fast path does an instance check, which fails onnp.ndarrays).