Skip to content

Add newline to end of configuration file on save #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
javidahmed64592 merged 2 commits into from
Dec 13, 2025
Merged

Add newline to end of configuration file on save #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b702c5
Add newline to end of configuration file on save
javidahmed64592 Dec 13, 2025
1050ac6
Add newline to end of configuration file on save in tests
javidahmed64592 Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions python_template_server/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ def save_to_file(self, filepath: Path) -> None:
"""
with filepath.open("w", encoding="utf-8") as config_file:
config_file.write(self.model_dump_json(indent=2))
config_file.write("\n")


# Prometheus Metric Models
Expand Down
2 changes: 1 addition & 1 deletion tests/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def test_save_to_file(
"""Test the save_to_file method."""
config_file = tmp_path / "config.json"
mock_template_server_config.save_to_file(config_file)
assert config_file.read_text(encoding="utf-8") == mock_template_server_config.model_dump_json(indent=2)
assert config_file.read_text(encoding="utf-8") == mock_template_server_config.model_dump_json(indent=2) + "\n"


# Prometheus Metric Models
Expand Down