Container Cluster Reverse Proxy Support #284
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR would resolve #283 |
jason0x43
requested changes
Aug 28, 2024
| event_url: str | None = user_input.get(H_CONF_SERVER_URL) | ||
| update_he_url: bool = user_input.get(H_CONF_UPDATE_HE_URL) |
| @@ -171,6 +175,8 @@ async def async_step_user( | |||
| H_CONF_SERVER_URL: user_input.get(H_CONF_SERVER_URL), | |||
| H_CONF_SERVER_SSL_CERT: user_input.get(H_CONF_SERVER_SSL_CERT), | |||
| H_CONF_SERVER_SSL_KEY: user_input.get(H_CONF_SERVER_SSL_KEY), | |||
| H_CONF_SERVER_INTERFACE: user_input.get(H_CONF_SERVER_INTERFACE), | |||
| H_CONF_UPDATE_HE_URL: user_input.get(H_CONF_UPDATE_HE_URL), | |||
There was a problem hiding this comment.
For backwards compatibility, I'd prefer this be something that could default to false (e.g., "Don't update event POST URL in Hubitat") because it's going to start out disabled for users after they update.
| @@ -124,12 +126,22 @@ def id(self) -> str: | |||
| def port(self) -> int | None: | |||
| """The port used for the Hubitat event receiver.""" | |||
| return self._hub.port | |||
|
|
|||
| @property | |||
| def address(self) -> str | None: | |||
There was a problem hiding this comment.
Is this property used anywhere?
|
|
||
| @property | ||
| def event_url(self) -> str | None: | ||
| """The event URL that Hubitat should POST events to.""" | ||
| return self._hub.event_url | ||
|
|
||
| @property | ||
| def update_he_url(self) -> bool | None: |
There was a problem hiding this comment.
Is this property used anywhere?
| self._server = server.create_server( | ||
| self._process_event, address, self.port or 0, self.ssl_context | ||
| self._process_event, self.address, self.port or 0, self.ssl_context |
There was a problem hiding this comment.
Make this self.address or '0.0.0.0' since create_server expects a string value.
| """ | ||
| if address is not None: | ||
| return address | ||
| if host is not None: |
There was a problem hiding this comment.
host should never be None since this is only called from the constructor, and the constructor must be passed a host value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow override of the server listening interface and disable HE POST URL updating.
Adds 2 new optional config options
This should allow anyone running Home Assistant in Docker Swarm or Kubernetes to use this integration.
Without the ability to set the listening interface, hosts with a dynamic container IP can not connect.
UI Example:
