Disable defaults #69
Open
Disable defaults #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d ports) Added an option to disable the default options "flags, ports and timeouts" called "noDefaults", check in the code if this option has value "true", if it does remove "ports and timeouts", the option "flags" is cleared because cannot be deleted because of checking the "-oX -" option.
In the tests I had to add a command to run the specific test "no-defaults.spec.js" because I have some kind of error in "discover"
Author
|
My deadline for this task is tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to disable the default options "flags, ports and timeouts" called "noDefaults", it's checked in the code if this option has value "true", if it does remove "ports and timeouts", the option "flags" is cleared because cannot be deleted because of checking the "-oX -" option. I did this because I implemented a solution and the client asked me not to have standard commands, and this was the easiest way I could think of comparing to developing my solution when one already exists.