chore: not attempt strategy more than one time#987
Open
Sczlog wants to merge 1 commit intojaredhanson:masterfrom
Open
chore: not attempt strategy more than one time#987Sczlog wants to merge 1 commit intojaredhanson:masterfrom
Sczlog wants to merge 1 commit intojaredhanson:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
some strategy doesn't handle error well which call
strategy.failmultiple time in one strategy, which make the next strategy(if exist) will be called multiple times unexpected.Change
this pr attend to limit one strategy should only be attempt once, as code not support es6, use object to store attmepted strategy's order and skip if was already attempted
Checklist
$ make test) executes successfully.$ make lint) executes successfully.