Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support tw vertical align utilities #284

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Conversation

menghany
Copy link
Contributor

@menghany menghany commented Mar 5, 2024

No description provided.

@jaredh159
Copy link
Owner

hi there! thanks for the PR!

i think CI will fail because of formatting things, a quick way to fix it is just run npm run lint:fix and npm run format.

question, is this PR essentially implementing the android-only verticalAlign text style prop from here? https://reactnative.dev/docs/text-style-props#verticalalign-android

(i'm fine adding an android-only utility, just want to be clear what these map to)

@menghany
Copy link
Contributor Author

menghany commented Mar 6, 2024

hi there! thanks for the PR!

i think CI will fail because of formatting things, a quick way to fix it is just run npm run lint:fix and npm run format.

question, is this PR essentially implementing the android-only verticalAlign text style prop from here? https://reactnative.dev/docs/text-style-props#verticalalign-android

(i'm fine adding an android-only utility, just want to be clear what these map to)

Yes, as you said. This is a text style prop that only exists on android.

@jaredh159
Copy link
Owner

ok, thanks. i'm good with this addition. but, before i merge, can you remove the new test file you created, and add the test cases to src/__tests__/simple-mappings.spec.ts instead? i think they fit in neatly there and don't warrant their own test file.

@menghany
Copy link
Contributor Author

menghany commented Mar 6, 2024

Sure, I have moved over.

@jaredh159 jaredh159 merged commit 9c7f6d5 into jaredh159:master Mar 6, 2024
1 check passed
@jaredh159
Copy link
Owner

released in v4.1.0. thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants