fix initial value of app color scheme #267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredh159
commented
Feb 6, 2024
| ); | ||
| const [colorScheme, setColorScheme] = useState(() => { | ||
| const init = initialValue ?? Appearance.getColorScheme(); | ||
| tw.setColorScheme(init); |
There was a problem hiding this comment.
here's the key (really, only) change -- we set the initial value into the tw object immediately, but only once (by leveraging a react initializer function).
|
No description provided. |
|
closing in favor of #271 @crjc i've got a PR up with my proposed changes, would you mind taking a quick look? #271 instructions for migrating (docs on breaking changes) here: https://github.com/jaredh159/tailwind-react-native-classnames/blob/f1997ae17273f35b31d446ff03dae2697e650414/migration-guide.md you can test it by installing a beta release with |
|
Looks good to me! |
|
thanks for checking it out. going to do a little more testing, then probably go with it. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.