Remove dependence on fn #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansel
requested changes
Apr 10, 2022
opentuner/search/manipulator.py
Outdated
| @@ -245,7 +244,7 @@ def hash_config(self, config): | |||
|
|
|||
| def search_space_size(self): | |||
| """estimate the size of the search space, not precise""" | |||
| return reduce(_ * _, [x.search_space_size() for x in self.params]) | |||
| return reduce(lambda n: n * n, [x.search_space_size() for x in self.params]) | |||
There was a problem hiding this comment.
I think this should be:
Suggested change
| return reduce(lambda n: n * n, [x.search_space_size() for x in self.params]) | |
| return reduce(lambda a, b: a * b, [x.search_space_size() for x in self.params]) |
Or operator.mul
There was a problem hiding this comment.
Fixed as suggested.
jansel
approved these changes
Apr 11, 2022
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python package
fn(https://github.com/kachayev/fn.py) is not actively maintained and OpenTuner only uses it for the_shortcut for creating lambdas and theStreamclass for concatenating iterators. More importantly,fnis incompatible with Python 3.9+ (kachayev/fn.py#86, kachayev/fn.py#91). This patch rewrites the uses offnin OpenTuner and removes the dependence.