Fix i3 configuration invalid and colors not read#108
Open
stablestud wants to merge 1 commit intojan-warchol:masterfrom
Open
Fix i3 configuration invalid and colors not read#108stablestud wants to merge 1 commit intojan-warchol:masterfrom
stablestud wants to merge 1 commit intojan-warchol:masterfrom
Conversation
Under i3status v2.13 the selenized config files are invalid, because the hashtag `#` is interpreted as a start of a comment and not as the begin of a color code. This commit quotes the values to make sure i3status interpretes these as colorcodes. Currently i3 interprets the colorcodes correctly, but to make sure its future proof the colorcodes in the i3 configs have been also quoted. Example: `color_good = #70b433` Is interpreted as comment, i3status throws an error. `color_good = "#70b433"` i3status correctly interprets the colorcode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under i3status v2.13 the selenized config files are invalid, because the hashtag
#is interpreted as a start of a comment and not as the begin of a color code.This commit quotes the values to make sure i3status interpretes these as colorcodes.
Currently i3 interprets the colorcodes correctly, but to make sure its future proof the colorcodes in the i3 configs have been also quoted.
Example:
Is interpreted as comment, i3status throws an error.
i3status correctly interprets the colorcode.