Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ class CounterContainer extends Container<CounterState> {
};

increment() {
this.setState({ count: this.state.count + 1 });
this.setState((prevState) => ({ count: prevState.count + 1 }));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cotainers are not React.Components, while they have same-ish setState method, it doesnt event yet allow callback-style argument - see #1

}

decrement() {
this.setState({ count: this.state.count - 1 });
this.setState((prevState) => ({ count: prevState.count - 1 }));
}
}

Expand Down Expand Up @@ -70,10 +70,10 @@ Component state is nice! It makes sense and people pick it up quickly:
class Counter extends React.Component {
state = { count: 0 };
increment = () => {
this.setState({ count: this.state.count + 1 });
this.setState((prevState) => ({ count: prevState.count + 1 }));
};
decrement = () => {
this.setState({ count: this.state.count - 1 });
this.setState((prevState) => ({ count: prevState.count - 1 }));
};
render() {
return (
Expand Down Expand Up @@ -107,8 +107,8 @@ const Amount = React.createContext(1);

class Counter extends React.Component {
state = { count: 0 };
increment = amount => { this.setState({ count: this.state.count + amount }); };
decrement = amount => { this.setState({ count: this.state.count - amount }); };
increment = amount => { this.setState((prevState) => ({ count: prevState.count + amount })); };
decrement = amount => { this.setState((prevState) => ({ count: prevState.count - amount })); };
render() {
return (
<Amount.Consumer>
Expand Down Expand Up @@ -177,10 +177,10 @@ updating it.
class CounterContainer extends Container {
state = { count: 0 };
increment = () => {
this.setState({ count: this.state.count + 1 });
this.setState((prevState) => ({ count: prevState.count + 1 }));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sam here, this setState method doesn't accept callback style

};
decrement = () => {
this.setState({ count: this.state.count - 1 });
this.setState((prevState) => ({ count: prevState.count - 1 }));
};
}
```
Expand Down
4 changes: 2 additions & 2 deletions __tests__/unstated.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ function render(element) {
class CounterContainer extends Container<{ count: number }> {
state = { count: 0 };
increment(amount = 1) {
this.setState({ count: this.state.count + amount });
this.setState(prevState => ({ count: prevState.count + amount }));
}
decrement(amount = 1) {
this.setState({ count: this.state.count - amount });
this.setState(prevState => ({ count: prevState.count - amount }));
}
}

Expand Down
4 changes: 2 additions & 2 deletions example/complex.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ class CounterContainer extends Container<CounterState> {
};

increment(amount: number) {
this.setState({ count: this.state.count + amount });
this.setState(prevState => ({ count: prevState.count + amount }));
}

decrement(amount: number) {
this.setState({ count: this.state.count - amount });
this.setState(prevState => ({ count: prevState.count - amount }));
}
}

Expand Down
4 changes: 2 additions & 2 deletions example/simple.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ class CounterContainer extends Container<CounterState> {
state = { count: 0 };

increment() {
this.setState({ count: this.state.count + 1 });
this.setState(prevState => ({ count: prevState.count + 1 }));
}

decrement() {
this.setState({ count: this.state.count - 1 });
this.setState(prevState => ({ count: prevState.count - 1 }));
}
}

Expand Down