Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hard coded kit name path and make building a lot easier v2 #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

doug65536
Copy link

Use qmake subdirs project to properly handle dependencies and avoid hard coding kit name paths for dependencies.

@doug65536
Copy link
Author

This replaces my old pull request at #1

@jamesst20
Copy link
Owner

Hey doug65536 ! :) Thanks you very much for this commit ! It does make sense to regroup both project together this way :)

However, I just tested and this is what I have :

No rule to make target 'C:/Users/James/Desktop/build-QtSnap-Desktop_Qt_5_4_0_MinGW_32bit-Debug/QtSnap-DemoApp/../QtSnap-Library/libQtSnap-Library.a', needed by 'debug\QtSnap-DemoApp.exe'. Stop.

The issue is in the pro file, you forgot to add a check for the debug/release folder :)

@doug65536
Copy link
Author

Are you cleaning the build directory and opening the top level QtSnap.pro? (The cleaning should only be necessary once)

@doug65536
Copy link
Author

I chose not to have separate debug and release folders, it adds a wall of ugly mess to the qmake. If you want that, I can update the pull request to use separate directories.

@jamesst20
Copy link
Owner

@doug65536

Yep the top level QtSnap.pro is open ;)

How should seperate release/debug folder be disabled then ? It just does it automatically on my side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants