Fix Azure OpenAI base URL construction #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base URL was incorrectly using a forward slash (/) instead of a dot (.) to construct the Azure OpenAI endpoint, resulting in malformed URLs like `https://{resourceName}/openai.azure.com` instead of the correct `https://{resourceName}.openai.azure.com`.
This caused DNS resolution failures when attempting to connect to Azure OpenAI services.
Reference: https://learn.microsoft.com/en-us/azure/ai-services/openai/reference
Fixes #139
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
/) to dot (.) in base URLProblem
The base URL was using:
This resulted in DNS resolution failures because it creates a malformed URL where
{resourceName}is treated as the entire hostname, and/openai.azure.comis treated as a path.Solution
Changed to the correct Azure OpenAI format:
This properly forms a subdomain structure that resolves correctly.
Reference
Test plan
https://{resourceName}.openai.azure.com/openai/deployments/{deployment-id}/...Fixes #139
🤖 Generated with Claude Code