Skip to content

Expand PSScriptAnalyzer coverage #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SamErde wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −2
Open

Expand PSScriptAnalyzer coverage #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59b7159
Expand PSScriptAnalyzer coverage
SamErde May 6, 2026
2203d9b
fix: add PSReviewUnusedParameter suppressions to Invoke-Locksmith.ps1…
SamErde May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/Create External Help.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ on:
# push:
workflow_dispatch:

permissions:
contents: read

jobs:
package_help:
# The New-ExternalHelpCab cmdlet uses makecab, which depends on Windows.
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/powershell.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ jobs:
# The below set up runs PSScriptAnalyzer to your entire repository and runs some basic security rules.
path: .\
recurse: true
# Include your own basic security rules. Removing this option will run all the rules
includeRule: '"PSAvoidGlobalAliases", "PSAvoidUsingConvertToSecureStringWithPlainText"'
# Run all rules except PSAvoidUsingWriteHost (Write-Host is used intentionally for progress output)
excludeRule: '"PSAvoidUsingWriteHost"'
output: results.sarif
Comment thread
SamErde marked this conversation as resolved.

# Upload the SARIF file generated in the previous step
Expand Down
2 changes: 2 additions & 0 deletions Invoke-Locksmith.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2789,6 +2789,8 @@ function Invoke-Scans {
[CmdletBinding()]
[OutputType([hashtable])]
[System.Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSUseSingularNouns', '', Justification = 'Performing multiple scans.')]
[System.Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSReviewUnusedParameter', 'EnrollmentAgentEKU', Justification = 'Parameter is part of the public API and reserved for future ESC13 enrollment-agent scan support.')]
[System.Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSReviewUnusedParameter', 'PreferredOwner', Justification = 'Parameter is part of the public API and reserved for planned remediation ownership integration.')]
param (
# Could split Scans and PromptMe into separate parameter sets.
[Parameter(Mandatory)]
Expand Down
2 changes: 2 additions & 0 deletions Private/Invoke-Scans.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ function Invoke-Scans {
[CmdletBinding()]
[OutputType([hashtable])]
[System.Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSUseSingularNouns', '', Justification = 'Performing multiple scans.')]
[System.Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSReviewUnusedParameter', 'EnrollmentAgentEKU', Justification = 'Parameter is part of the public API and reserved for future ESC13 enrollment-agent scan support.')]
[System.Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSReviewUnusedParameter', 'PreferredOwner', Justification = 'Parameter is part of the public API and reserved for planned remediation ownership integration.')]
Comment thread
SamErde marked this conversation as resolved.
param (
# Could split Scans and PromptMe into separate parameter sets.
[Parameter(Mandatory)]
Expand Down
Loading