Skip to content

Optimize hot-path array accumulation #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SamErde wants to merge 4 commits into
base: main
Choose a base branch
from
+17 −9
Open

Optimize hot-path array accumulation #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4031b89
Optimize ESC3 scan array accumulation to avoid intermediate copy
SamErde May 6, 2026
fb09787
Use single ESC3 array materialization
SamErde May 6, 2026
49cd743
fix: use single array subexpression for ESC3 accumulation
SamErde May 6, 2026
a90022c
Update generated ESC3 accumulation
SamErde May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions Invoke-Locksmith.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[CmdletBinding(HelpUri = 'https://jakehildreth.github.io/Locksmith/Invoke-Locksmith')]
[CmdletBinding(HelpUri = 'https://jakehildreth.github.io/Locksmith/Invoke-Locksmith')]
Comment thread
SamErde marked this conversation as resolved.
param (
# The mode to run Locksmith in. Defaults to 0.
[Parameter(Mandatory = $false)]
Expand Down Expand Up @@ -2849,8 +2849,10 @@ function Invoke-Scans {
}
ESC3 {
Write-Host 'Identifying AD CS templates with dangerous ESC3 configurations...'
[array]$ESC3 = Find-ESC3C1 -ADCSObjects $ADCSObjects -SafeUsers $SafeUsers -UnsafeUsers $UnsafeUsers
[array]$ESC3 += Find-ESC3C2 -ADCSObjects $ADCSObjects -SafeUsers $SafeUsers -UnsafeUsers $UnsafeUsers
[array]$ESC3 = @(
Find-ESC3C1 -ADCSObjects $ADCSObjects -SafeUsers $SafeUsers -UnsafeUsers $UnsafeUsers
Find-ESC3C2 -ADCSObjects $ADCSObjects -SafeUsers $SafeUsers -UnsafeUsers $UnsafeUsers
)
}
ESC4 {
Write-Host 'Identifying AD CS templates with poor access control (ESC4)...'
Expand Down Expand Up @@ -2908,8 +2910,10 @@ function Invoke-Scans {
Write-Host 'Identifying AD CS templates with dangerous ESC2 configurations...'
[array]$ESC2 = Find-ESC2 -ADCSObjects $ADCSObjects -SafeUsers $SafeUsers -UnsafeUsers $UnsafeUsers
Write-Host 'Identifying AD CS templates with dangerous ESC3 configurations...'
[array]$ESC3 = Find-ESC3C1 -ADCSObjects $ADCSObjects -SafeUsers $SafeUsers -UnsafeUsers $UnsafeUsers
[array]$ESC3 += Find-ESC3C2 -ADCSObjects $ADCSObjects -SafeUsers $SafeUsers -UnsafeUsers $UnsafeUsers
[array]$ESC3 = @(
Find-ESC3C1 -ADCSObjects $ADCSObjects -SafeUsers $SafeUsers -UnsafeUsers $UnsafeUsers
Find-ESC3C2 -ADCSObjects $ADCSObjects -SafeUsers $SafeUsers -UnsafeUsers $UnsafeUsers
)
Write-Host 'Identifying AD CS templates with poor access control (ESC4)...'
[array]$ESC4 = Find-ESC4 -ADCSObjects $ADCSObjects -SafeUsers $SafeUsers -DangerousRights $DangerousRights -SafeOwners $SafeOwners -SafeObjectTypes $SafeObjectTypes -Mode $Mode -UnsafeUsers $UnsafeUsers
Write-Host 'Identifying AD CS objects with poor access control (ESC5)...'
Expand Down
12 changes: 8 additions & 4 deletions Private/Invoke-Scans.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,10 @@ function Invoke-Scans {
}
ESC3 {
Write-Host 'Identifying AD CS templates with dangerous ESC3 configurations...'
[array]$ESC3 = Find-ESC3C1 -ADCSObjects $ADCSObjects -SafeUsers $SafeUsers -UnsafeUsers $UnsafeUsers
[array]$ESC3 += Find-ESC3C2 -ADCSObjects $ADCSObjects -SafeUsers $SafeUsers -UnsafeUsers $UnsafeUsers
[array]$ESC3 = @(
Find-ESC3C1 -ADCSObjects $ADCSObjects -SafeUsers $SafeUsers -UnsafeUsers $UnsafeUsers
Find-ESC3C2 -ADCSObjects $ADCSObjects -SafeUsers $SafeUsers -UnsafeUsers $UnsafeUsers
)
Comment thread
SamErde marked this conversation as resolved.
}
ESC4 {
Write-Host 'Identifying AD CS templates with poor access control (ESC4)...'
Expand Down Expand Up @@ -147,8 +149,10 @@ function Invoke-Scans {
Write-Host 'Identifying AD CS templates with dangerous ESC2 configurations...'
[array]$ESC2 = Find-ESC2 -ADCSObjects $ADCSObjects -SafeUsers $SafeUsers -UnsafeUsers $UnsafeUsers
Write-Host 'Identifying AD CS templates with dangerous ESC3 configurations...'
[array]$ESC3 = Find-ESC3C1 -ADCSObjects $ADCSObjects -SafeUsers $SafeUsers -UnsafeUsers $UnsafeUsers
[array]$ESC3 += Find-ESC3C2 -ADCSObjects $ADCSObjects -SafeUsers $SafeUsers -UnsafeUsers $UnsafeUsers
[array]$ESC3 = @(
Find-ESC3C1 -ADCSObjects $ADCSObjects -SafeUsers $SafeUsers -UnsafeUsers $UnsafeUsers
Find-ESC3C2 -ADCSObjects $ADCSObjects -SafeUsers $SafeUsers -UnsafeUsers $UnsafeUsers
)
Write-Host 'Identifying AD CS templates with poor access control (ESC4)...'
[array]$ESC4 = Find-ESC4 -ADCSObjects $ADCSObjects -SafeUsers $SafeUsers -DangerousRights $DangerousRights -SafeOwners $SafeOwners -SafeObjectTypes $SafeObjectTypes -Mode $Mode -UnsafeUsers $UnsafeUsers
Write-Host 'Identifying AD CS objects with poor access control (ESC5)...'
Expand Down
Loading