Refactor VideoModal to ES-module initializer; use object mapping

[aman-arabzadeh]

No description provided.

[netlify]

✅ Deploy Preview for jakartaee ready!

Name	Link
🔨 Latest commit	942c301
🔍 Latest deploy log	https://app.netlify.com/projects/jakartaee/deploys/68370e954f21e80008295a59
😎 Deploy Preview	https://deploy-preview-2176--jakartaee.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[oliviergoulet5]

Thanks for submitting the PR @aman-arabzadeh!

A few things to note:

1. You will need to create an Eclipse account and sign the Eclipse Contributor Agreement before we can merge this into the codebase. You can see that there is a status check for this, and it is currently failing.
2. This code is no longer running. The VideoModal function is no longer being invoked in your patch. It used to be an IIFE.
3. You swapped the strings from single quotes to double quotes. Our codebase uses single quotes.

Aside from those three points, the refactor looks good! We appreciate your support.

[aman-arabzadeh]

Hi Olivier, I attempted to create an account as a contributor, but the email validator on the form is rejecting my email address because it contains a dot before the "@" symbol. This was frustrating, especially since this is a standard, valid email format. Initially, I also ran into an issue with quotes—my IDE automatically changed single quotes to double quotes. I've since updated the settings, and it now respects single quotes as required. I’ve sent an email to ***@***.*** but haven’t received a response yet. Here's the message I sent:" Hello Eclipse Team, I'm trying to create an account for the Eclipse Contributor Agreement (ECA) to support a GitHub pull request, but your web form is rejecting my primary email address due to what appears to be a validation issue—possibly a regex mismatch. Email: ***@***.*** The form reports: "Your email address must not include plus signs (+) or dots (.)" However, this is the same address used in my GitHub commits, and it's fully active. Due to this validation bug, I’m unable to complete the ECA process. On the pull request, I’m getting the following error: "Author Eclipse account cannot be found. Email: ***@***.****il DOT com, GitHub ID: aman-arabzadeh" As you can see, the email is being incorrectly obfuscated, and I’m not sure why. I’ve double-checked my local, global, and GitHub settings, and everything is correct. Here's the output from my local config test:" git show -s --format='Commit: %h

> Author: %ae > Committer: %ce' e2d8e27 >

Commit: e2d8e27 Author: ***@***.*** Committer: ***@***.***" Could you please manually confirm my ECA under the email ***@***.*** so that my pull request can pass the eclipsefdn/eca check? or help me create an account. The PR is here: #2176 Thank you very much for your help! Best regards, Aman ***@***.***)" Den ons 28 maj 2025 kl 14:51 skrev Olivier Goulet ***@***.***

…

: *oliviergoulet5* left a comment (jakartaee/jakarta.ee#2176) <#2176 (comment)> Thanks for submitting the PR @aman-arabzadeh <https://github.com/aman-arabzadeh>! A few things to note: 1. You will need to create an Eclipse account and sign the Eclipse Contributor Agreement <https://accounts.eclipse.org/user/eca> before we can merge this into the codebase. You can see that there is a status check for this, and it is currently failing. 2. This code is no longer running. The VideoModal function is no longer being invoked in your patch. It used to be an IIFE <https://developer.mozilla.org/en-US/docs/Glossary/IIFE>. 3. You swapped the strings from single quotes to double quotes. Our codebase uses single quotes. Aside from those three points, the refactor looks good! We appreciate your support. — Reply to this email directly, view it on GitHub <#2176 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOOA5EWF3D7O5AWGZ7GU7NL3AWWLZAVCNFSM6AAAAAB6BP2E6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMJWGE4TKMRYGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>