Skip to content

Conversation

@iypetrov
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • Draft: the goal is to add a new configuration field that specifies the max trace size in bytes that query service could load and add the proper validations, warning and tests.

How was this change tested?

  • Draft: unit tests

Checklist

@iypetrov iypetrov requested a review from a team as a code owner January 15, 2026 15:58
@iypetrov iypetrov requested a review from jkowall January 15, 2026 15:58
@dosubot dosubot bot added the enhancement label Jan 15, 2026
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.22%. Comparing base (aa617a6) to head (ee93030).
⚠️ Report is 5 commits behind head on main.

❌ Your project status has failed because the head coverage (39.22%) is below the target coverage (95.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (aa617a6) and HEAD (ee93030). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (aa617a6) HEAD (ee93030)
unittests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7876       +/-   ##
===========================================
- Coverage   95.50%   39.22%   -56.28%     
===========================================
  Files         305      166      -139     
  Lines       16174     9843     -6331     
===========================================
- Hits        15447     3861    -11586     
- Misses        570     5583     +5013     
- Partials      157      399      +242     
Flag Coverage Δ
badger_v1 9.19% <ø> (ø)
badger_v2 1.94% <ø> (ø)
cassandra-4.x-v1-manual 13.59% <ø> (ø)
cassandra-4.x-v2-auto 1.93% <ø> (ø)
cassandra-4.x-v2-manual 1.93% <ø> (ø)
cassandra-5.x-v1-manual 13.59% <ø> (ø)
cassandra-5.x-v2-auto 1.93% <ø> (ø)
cassandra-5.x-v2-manual 1.93% <ø> (ø)
clickhouse 1.98% <ø> (?)
elasticsearch-6.x-v1 17.54% <ø> (ø)
elasticsearch-7.x-v1 17.58% <ø> (ø)
elasticsearch-8.x-v1 17.73% <ø> (ø)
elasticsearch-8.x-v2 1.94% <ø> (ø)
elasticsearch-9.x-v2 1.94% <ø> (ø)
grpc_v1 8.85% <ø> (ø)
grpc_v2 1.94% <ø> (ø)
kafka-3.x-v2 1.94% <ø> (ø)
memory_v2 1.94% <ø> (ø)
opensearch-1.x-v1 17.62% <ø> (ø)
opensearch-2.x-v1 17.62% <ø> (ø)
opensearch-2.x-v2 1.94% <ø> (ø)
opensearch-3.x-v2 1.94% <ø> (ø)
query 1.94% <ø> (ø)
tailsampling-processor 0.55% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Jan 15, 2026

Metrics Comparison Summary

Total changes across all snapshots: 0

Detailed changes per snapshot

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

Total Changes: 0

  • 🆕 Added: 0 metrics
  • ❌ Removed: 0 metrics
  • 🔄 Modified: 0 metrics
  • 🚫 Excluded: 106 metrics

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

Total Changes: 0

  • 🆕 Added: 0 metrics
  • ❌ Removed: 0 metrics
  • 🔄 Modified: 0 metrics
  • 🚫 Excluded: 53 metrics

➡️ View full metrics file

@@ -1,4 +1,4 @@
// Copyright (c) 2019,2020 The Jaeger Authors.
// Copyright (cQueryOptions ) 2019,2020 The Jaeger Authors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copyright notice has been corrupted with (cQueryOptions ) instead of (c). This appears to be an accidental edit.

Should be:

// Copyright (c) 2019,2020 The Jaeger Authors.
Suggested change
// Copyright (cQueryOptions ) 2019,2020 The Jaeger Authors.
// Copyright (c) 2019,2020 The Jaeger Authors.

Spotted by Graphite Agent

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

@Parship12
Copy link
Contributor

#7810
there is an existing PR in progress for this

@iypetrov
Copy link
Contributor Author

#7810 there is an existing PR in progress for this

sorry, though this PR is abandoned

@iypetrov iypetrov closed this Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Implement max trace size parameter in the query service

2 participants