-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Draft: ISSUE-7495: Implement MaxTracesSize parameter in query service #7876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: ISSUE-7495: Implement MaxTracesSize parameter in query service #7876
Conversation
Signed-off-by: Ilia Petrov <[email protected]>
Signed-off-by: Ilia Petrov <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (39.22%) is below the target coverage (95.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## main #7876 +/- ##
===========================================
- Coverage 95.50% 39.22% -56.28%
===========================================
Files 305 166 -139
Lines 16174 9843 -6331
===========================================
- Hits 15447 3861 -11586
- Misses 570 5583 +5013
- Partials 157 399 +242
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Metrics Comparison SummaryTotal changes across all snapshots: 0 Detailed changes per snapshotsummary_metrics_snapshot_cassandra📊 Metrics Diff SummaryTotal Changes: 0
summary_metrics_snapshot_cassandra📊 Metrics Diff SummaryTotal Changes: 0
|
Signed-off-by: Ilia Petrov <[email protected]>
| @@ -1,4 +1,4 @@ | |||
| // Copyright (c) 2019,2020 The Jaeger Authors. | |||
| // Copyright (cQueryOptions ) 2019,2020 The Jaeger Authors. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The copyright notice has been corrupted with (cQueryOptions ) instead of (c). This appears to be an accidental edit.
Should be:
// Copyright (c) 2019,2020 The Jaeger Authors.| // Copyright (cQueryOptions ) 2019,2020 The Jaeger Authors. | |
| // Copyright (c) 2019,2020 The Jaeger Authors. |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
|
#7810 |
sorry, though this PR is abandoned |
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test