Validate span names in SPM integration test #7830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don-Assamongkol1
force-pushed
the
5608-SPM-verify-labels-PR
branch
3 times, most recently
from
ffaee83 to
f336dcb
Compare
Don-Assamongkol1
force-pushed
the
5608-SPM-verify-labels-PR
branch
from
f336dcb to
100fe52
Compare
Don-Assamongkol1
commented
Jan 4, 2026
Comment on lines
+129
to
+153
| case "$service" in | ||
| "driver") | ||
| echo "/FindNearest" | ||
| ;; | ||
| "customer") | ||
| echo "/customer" | ||
| ;; | ||
| "mysql") | ||
| echo "/sql_select" | ||
| ;; | ||
| "redis") | ||
| echo "/FindDriverIDs /GetDriver" | ||
| ;; | ||
| "frontend") | ||
| echo "/dispatch" | ||
| ;; | ||
| "route") | ||
| echo "/GetShortestRoute" | ||
| ;; | ||
| "ui") | ||
| echo "/" | ||
| ;; | ||
| *) | ||
| echo "" | ||
| ;; | ||
| esac |
Contributor
Author
There was a problem hiding this comment.
Not sure if I could've made this cleaner -- would've used a hashmap but I believe there's no such thing in bash
yurishkuro
reviewed
Jan 7, 2026
scripts/e2e/spm.sh
Outdated
|
|
||
| set -x | ||
| # Enable verbose logs if you want to debug the script. Else, keep logs clean. | ||
| # set -x |
Member
There was a problem hiding this comment.
but the time the script fails in CI it's too late to enable logs. I prefer this option on.
Contributor
Author
There was a problem hiding this comment.
Makes sense. Reverted to on
Member
|
lgtm |
yurishkuro
added
the
changelog:ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7830 +/- ##
==========================================
+ Coverage 95.49% 95.51% +0.01%
==========================================
Files 307 307
Lines 15911 15911
==========================================
+ Hits 15195 15197 +2
+ Misses 562 561 -1
+ Partials 154 153 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Metrics Comparison SummaryTotal changes across all snapshots: 0 Detailed changes per snapshotsummary_metrics_snapshot_cassandra📊 Metrics Diff SummaryTotal Changes: 0
summary_metrics_snapshot_cassandra📊 Metrics Diff SummaryTotal Changes: 0
|
Member
|
please rebase on main |
Signed-off-by: Don Assamongkol <[email protected]>
Don-Assamongkol1
force-pushed
the
5608-SPM-verify-labels-PR
branch
from
100fe52 to
f632102
Compare
yurishkuro
approved these changes
Jan 7, 2026
Member
|
I will override the dco-lint, but you may want to fix your git vs. github settings to use the full name |
Member
|
thanks |
Contributor
Author
Ah! Thanks for pointing that out. Will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Partially resolves #5608:
Description of the changes
validate_service_metricsfunction: grab the response from querying the metrics API then verify that the spans emitted have names for what we'd expect for that service.How was this change tested?
Run the e2e test locally:
(had to change registry port on my machine, but did not add that code change here)
Log excerpts:
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test