[WIP] Rework ClickHouse Attributes to look up type for string attributes #7815

mahadzaryab1 · 2026-01-01T17:16:18Z

Which problem is this PR solving?

Towards [clickhouse] Implement Trace Reader For ClickHouse Storage #7134

Description of the changes

How was this change tested?

Checklist

I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
I have signed all commits
I have added unit tests for the new functionality
I have run lint and test steps successfully
- for jaeger: make lint test
- for jaeger-ui: npm run lint and npm run test

Signed-off-by: Mahad Zaryab <[email protected]>

codecov · 2026-01-01T17:27:51Z

Codecov Report

❌ Patch coverage is 0% with 160 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.83%. Comparing base (7193099) to head (a141a2a).

Files with missing lines	Patch %	Lines
...nternal/storage/v2/clickhouse/tracestore/reader.go	0.00%	130 Missing ⚠️
...age/v2/clickhouse/tracestore/attribute_metadata.go	0.00%	30 Missing ⚠️

❌ Your project check has failed because the head coverage (38.83%) is below the target coverage (95.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (7193099) and HEAD (a141a2a). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (7193099) HEAD (a141a2a)

unittests 1 0

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #7815       +/-   ##
===========================================
- Coverage   95.53%   38.83%   -56.71%     
===========================================
  Files         307      167      -140     
  Lines       15911     9961     -5950     
===========================================
- Hits        15201     3868    -11333     
- Misses        558     5698     +5140     
- Partials      152      395      +243

Flag	Coverage Δ
badger_v1	`9.06% <0.00%> (-0.13%)`	⬇️
badger_v2	`1.90% <0.00%> (-0.03%)`	⬇️
cassandra-4.x-v1-manual	`13.41% <0.00%> (-0.18%)`	⬇️
cassandra-4.x-v2-auto	`1.89% <0.00%> (-0.03%)`	⬇️
cassandra-4.x-v2-manual	`1.89% <0.00%> (-0.03%)`	⬇️
cassandra-5.x-v1-manual	`13.41% <0.00%> (-0.18%)`	⬇️
cassandra-5.x-v2-auto	`1.89% <0.00%> (-0.03%)`	⬇️
cassandra-5.x-v2-manual	`1.89% <0.00%> (-0.03%)`	⬇️
clickhouse	`2.06% <0.00%> (+0.09%)`	⬆️
elasticsearch-6.x-v1	`17.31% <0.00%> (-0.24%)`	⬇️
elasticsearch-7.x-v1	`17.34% <0.00%> (-0.24%)`	⬇️
elasticsearch-8.x-v1	`17.49% <0.00%> (-0.24%)`	⬇️
elasticsearch-8.x-v2	`1.90% <0.00%> (-0.03%)`	⬇️
elasticsearch-9.x-v2	`1.90% <0.00%> (-0.03%)`	⬇️
grpc_v1	`8.73% <0.00%> (-0.12%)`	⬇️
grpc_v2	`1.90% <0.00%> (-0.03%)`	⬇️
kafka-3.x-v2	`1.90% <0.00%> (-0.03%)`	⬇️
memory_v2	`1.90% <0.00%> (-0.03%)`	⬇️
opensearch-1.x-v1	`17.39% <0.00%> (-0.24%)`	⬇️
opensearch-2.x-v1	`17.39% <0.00%> (-0.24%)`	⬇️
opensearch-2.x-v2	`1.90% <0.00%> (-0.03%)`	⬇️
opensearch-3.x-v2	`1.90% <0.00%> (-0.03%)`	⬇️
query	`1.90% <0.00%> (-0.03%)`	⬇️
tailsampling-processor	`0.55% <0.00%> (-0.01%)`	⬇️
unittests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Mahad Zaryab <[email protected]>

github-actions · 2026-01-01T21:03:55Z

Metrics Comparison Summary

Total changes across all snapshots: 54

Detailed changes per snapshot

summary_metrics_snapshot_clickhouse

📊 Metrics Diff Summary

Total Changes: 54

🆕 Added: 0 metrics
❌ Removed: 54 metrics
🔄 Modified: 0 metrics

❌ Removed Metrics

rpc_server_duration_milliseconds (18 variants)

View diff sample

-rpc_server_duration_milliseconds{le="+Inf",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="2",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
-rpc_server_duration_milliseconds{le="0",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="2",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
-rpc_server_duration_milliseconds{le="10",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="2",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
-rpc_server_duration_milliseconds{le="100",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="2",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
-rpc_server_duration_milliseconds{le="1000",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="2",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
-rpc_server_duration_milliseconds{le="10000",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="2",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
-rpc_server_duration_milliseconds{le="25",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="2",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
...

- `rpc_server_requests_per_rpc` (18 variants)

View diff sample

-rpc_server_requests_per_rpc{le="+Inf",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="2",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
-rpc_server_requests_per_rpc{le="0",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="2",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
-rpc_server_requests_per_rpc{le="10",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="2",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
-rpc_server_requests_per_rpc{le="100",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="2",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
-rpc_server_requests_per_rpc{le="1000",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="2",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
-rpc_server_requests_per_rpc{le="10000",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="2",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
-rpc_server_requests_per_rpc{le="25",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="2",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
...

- `rpc_server_responses_per_rpc` (18 variants)

View diff sample

-rpc_server_responses_per_rpc{le="+Inf",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="2",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
-rpc_server_responses_per_rpc{le="0",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="2",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
-rpc_server_responses_per_rpc{le="10",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="2",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
-rpc_server_responses_per_rpc{le="100",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="2",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
-rpc_server_responses_per_rpc{le="1000",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="2",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
-rpc_server_responses_per_rpc{le="10000",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="2",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
-rpc_server_responses_per_rpc{le="25",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="2",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
...

➡️ View full metrics file

internal/storage/v2/clickhouse/tracestore/dbmodel/attribute_metadata.go

yurishkuro · 2026-01-01T22:05:16Z

internal/storage/v2/clickhouse/tracestore/reader.go

+
+// getAttributeMetadata retrieves the types stored in ClickHouse for string attributes.
+//
+// The query service forwards all attribute filters as strings (via AsString()), regardless


is that true? iirc the UI sends the attributes as JSON, which mean at least numeric types might be coming not as strings, but then there is another translation layer from HTTL handler into AttributeMap in the QueryService

yurishkuro · 2026-01-01T22:06:10Z

internal/storage/v2/clickhouse/tracestore/reader.go

+//
+// Only string-typed attributes from the query are looked up, since other types
+// (bool, int, double, etc.) are already correctly typed in the query parameters.
+func (r *Reader) getAttributeMetadata(attributes pcommon.Map) (attributeMetadata, error) {


I would move this into a separate file, e.g. attribute_metadata.go in this package

yurishkuro · 2026-01-01T22:11:29Z

internal/storage/v2/clickhouse/tracestore/reader.go

-	for key, attr := range query.Attributes.All() {
-		var attrType string
-		var val any
+	attributeMetadata, err := r.getAttributeMetadata(query.Attributes)


I think we will need to introduce some cache TTL parameter such that we don't keep running this query on every other query. The metadata doesn't change frequently.

Should this cache TTL parameter be exposed in the config? I can do this in following a PR

yes it should be configurable but with sensible default

Signed-off-by: Mahad Zaryab <[email protected]>

yurishkuro · 2026-01-03T21:35:30Z

internal/storage/v2/clickhouse/tracestore/reader.go

+	if err != nil {
+		return "", nil, fmt.Errorf("failed to get attribute metadata: %w", err)
+	}
+	fmt.Printf("Attribute metadata: %+v\n", attributeMetadata)


) ## Which problem is this PR solving? - Towards #7134 ## Description of the changes - Update the ClickHouse test driver which is used in unit tests to handle multiple queries. This is done in preparation for #7815 which adds an additional query to the attribute_metadata table. ## How was this change tested? - CI and unit tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <[email protected]>

mahadzaryab1 added 4 commits December 31, 2025 18:27

Add Helper For Building Attribute Metadata Query

3f3cfbd

Signed-off-by: Mahad Zaryab <[email protected]>

Add AttributeMetadata Type

1f0f2aa

Signed-off-by: Mahad Zaryab <[email protected]>

Query Metadata Attribute Table

3ce6ccf

Signed-off-by: Mahad Zaryab <[email protected]>

Format

40f145e

Signed-off-by: Mahad Zaryab <[email protected]>

Add ClickHouse Tags

ad67ac6

Signed-off-by: Mahad Zaryab <[email protected]>

mahadzaryab1 added the changelog:experimental Change to an experimental part of the code label Jan 1, 2026

mahadzaryab1 added 5 commits January 1, 2026 12:49

Remove SkipList

e21229a

Signed-off-by: Mahad Zaryab <[email protected]>

Fix

0ef0e09

Signed-off-by: Mahad Zaryab <[email protected]>

Add Debug Statements

117c8d7

Signed-off-by: Mahad Zaryab <[email protected]>

Update SkipList

15ebaff

Signed-off-by: Mahad Zaryab <[email protected]>

Update SkipList

4943726

Signed-off-by: Mahad Zaryab <[email protected]>

yurishkuro reviewed Jan 1, 2026

View reviewed changes

mahadzaryab1 added 2 commits January 3, 2026 16:28

Address Feedback

2cb8f63

Signed-off-by: Mahad Zaryab <[email protected]>

Format

269de1d

Signed-off-by: Mahad Zaryab <[email protected]>

yurishkuro reviewed Jan 3, 2026

View reviewed changes

Merge branch 'main' into attribute-metadata-queries

a141a2a

mahadzaryab1 mentioned this pull request Jan 7, 2026

[clickhouse][chore] Update test driver to handle multiple queries #7839

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[WIP] Rework ClickHouse Attributes to look up type for string attributes #7815

[WIP] Rework ClickHouse Attributes to look up type for string attributes #7815

mahadzaryab1 commented Jan 1, 2026

Uh oh!

codecov bot commented Jan 1, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 1, 2026 •

edited

Loading

summary_metrics_snapshot_clickhouse

📊 Metrics Diff Summary

❌ Removed Metrics

Uh oh!

Uh oh!

yurishkuro Jan 1, 2026

Uh oh!

yurishkuro Jan 1, 2026

Uh oh!

yurishkuro Jan 1, 2026

Uh oh!

mahadzaryab1 Jan 3, 2026

Uh oh!

yurishkuro Jan 3, 2026

Uh oh!

yurishkuro Jan 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[WIP] Rework ClickHouse Attributes to look up type for string attributes #7815

Are you sure you want to change the base?

[WIP] Rework ClickHouse Attributes to look up type for string attributes #7815

Conversation

mahadzaryab1 commented Jan 1, 2026

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

Uh oh!

codecov bot commented Jan 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jan 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Metrics Comparison Summary

summary_metrics_snapshot_clickhouse

📊 Metrics Diff Summary

❌ Removed Metrics

Uh oh!

Uh oh!

yurishkuro Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

yurishkuro Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

yurishkuro Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

mahadzaryab1 Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

yurishkuro Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

yurishkuro Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Jan 1, 2026 •

edited

Loading

github-actions bot commented Jan 1, 2026 •

edited

Loading