-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat: add Grafana dashboards for Jaeger v2 metrics (Issue #7811) #7813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add Grafana dashboards for Jaeger v2 metrics (Issue #7811) #7813
Conversation
…ng#7811) Signed-off-by: Anand Singh <[email protected]>
Signed-off-by: Anand Singh <[email protected]>
19e2bdc to
c4e4f81
Compare
|
is monitoring/jaeger-mixin/README.md still accurate after these changes? |
Signed-off-by: Anand Singh <[email protected]>
Signed-off-by: Anand Singh <[email protected]>
I've updated the README to remove the now-obsolete warning about V2 metric incompatibility. Since the default dashboard and alerts are now V2-native, the documentation is consistent with the code. |
Signed-off-by: Anand Singh <[email protected]>
Signed-off-by: Anand Singh <[email protected]>
|
|
||
| .PHONY: lint | ||
| lint: lint-fmt lint-license lint-imports lint-semconv lint-goversion lint-goleak lint-go | ||
| lint: lint-fmt lint-license lint-imports lint-semconv lint-goversion lint-goleak lint-go lint-monitoring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not something we change that often to include this in the main lint target. We can add a workflow that is only executed if files in this dir are changed.
| cd monitoring/jaeger-mixin | ||
|
|
||
| # Install dependencies | ||
| ~/go/bin/jb install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no guarantee that this is where go installs binaries. You can use the approach we have in internal/tools, add a separate target to scripts/makefiles/Tools.mk
Metrics Comparison SummaryTotal changes across all snapshots: 7 Detailed changes per snapshotsummary_metrics_snapshot_kafka📊 Metrics Diff SummaryTotal Changes: 7
🔄 Modified Metrics
|
Which problem is this PR solving?
Description of the changes
jaeger-v2.jsonin [monitoring/jaeger-mixin/dashboards.libsonnet] that uses OpenTelemetry Collector metrics (otelcol_*) instead of legacy Jaeger metrics.qpsPanelSuccessErrorto [dashboards.libsonnet] to streamline panel creation.otelcol_receiver_accepted_spans,otelcol_exporter_queue_size).How was this change tested?
jbto ensure valid syntax and successful compilation.otelcol_metrics and that the panel structure is correct.Checklist
make lint testjaeger-ui:npm run lintandnpm run test