-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[test] Refactor integration tests to directly write/read ptrace.Traces
#7812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Manik2708
wants to merge
17
commits into
jaegertracing:main
Choose a base branch
from
Manik2708:e2e-reader
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
0476f4c
[test] Refactor integration tests to directly write/read ptrace.Traces
Manik2708 a934c94
cleanup
Manik2708 10c9687
Merge branch 'main' into e2e-reader
Manik2708 76c0000
add test package
Manik2708 03deba9
cleanup
Manik2708 f6efd94
test fix
Manik2708 01deee6
test fix
Manik2708 ea31392
Merge branch 'main' into e2e-reader
Manik2708 8c84e5b
clickhouse fix
Manik2708 b606b8e
cleanup
Manik2708 d8fc9b2
cleanup
Manik2708 b23e043
Merge branch 'main' into e2e-reader
Manik2708 ad4c621
batch size fix
Manik2708 9d581bc
Merge branch 'main' into e2e-reader
Manik2708 5b7950c
dates test
Manik2708 0c523d5
spelling fix
Manik2708 170b68b
Merge branch 'main' into e2e-reader
Manik2708 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| // Copyright (c) 2026 The Jaeger Authors. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package integration | ||
|
|
||
| import ( | ||
| "time" | ||
|
|
||
| "go.opentelemetry.io/collector/pdata/pcommon" | ||
| ) | ||
|
|
||
| // dateOffsetNormalizer normalizes timestamps by replacing their date | ||
| // (year, month, day) with a fixed date computed using a day offset | ||
| // from the current UTC date, while preserving the original time | ||
| // This is required in integration tests because the fixtures have | ||
| // hardcoded start time and other time stamps and we need to make | ||
| // recent to fetch from the reader. | ||
| type dateOffsetNormalizer struct { | ||
| year, day int | ||
| month time.Month | ||
| } | ||
|
|
||
| func newDateOffsetNormalizer(dayOffset int) dateOffsetNormalizer { | ||
| now := time.Now().UTC() | ||
| d := dateOffsetNormalizer{} | ||
| d.year, d.month, d.day = now.AddDate(0, 0, dayOffset).Date() | ||
| return d | ||
| } | ||
|
|
||
| func (d dateOffsetNormalizer) normalize(t pcommon.Timestamp) pcommon.Timestamp { | ||
| tm := t.AsTime() | ||
| newTm := time.Date( | ||
| d.year, | ||
| d.month, | ||
| d.day, | ||
| tm.Hour(), | ||
| tm.Minute(), | ||
| tm.Second(), | ||
| tm.Nanosecond(), | ||
| tm.Location(), | ||
| ) | ||
| return pcommon.NewTimestampFromTime(newTm) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| // Copyright (c) 2026 The Jaeger Authors. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package integration | ||
|
|
||
| import ( | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| "go.opentelemetry.io/collector/pdata/pcommon" | ||
| ) | ||
|
|
||
| func Test_dateOffsetNormalizer(t *testing.T) { | ||
| origTime := time.Date( | ||
| 2024, time.January, 10, | ||
| 14, 30, 45, 123456789, | ||
| time.UTC, | ||
| ) | ||
| origTs := pcommon.NewTimestampFromTime(origTime) | ||
| dayOffset := -2 | ||
| normalizer := newDateOffsetNormalizer(dayOffset) | ||
| normalizedTs := normalizer.normalize(origTs) | ||
| normalizedTime := normalizedTs.AsTime() | ||
| expectedDate := time.Now().UTC().AddDate(0, 0, dayOffset) | ||
| expectedTime := time.Date( | ||
| expectedDate.Year(), | ||
| expectedDate.Month(), | ||
| expectedDate.Day(), | ||
| origTime.Hour(), | ||
| origTime.Minute(), | ||
| origTime.Second(), | ||
| origTime.Nanosecond(), | ||
| time.UTC, | ||
| ) | ||
| assert.Equal(t, expectedTime, normalizedTime) | ||
| } | ||
Manik2708 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reducing to this has passed the tests