Skip to content

Conversation

@Manik2708
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • This PR refactors the converters to directly convert ptrace.Trace to database models of cassandra

How was this change tested?

  • Unit Tests

Checklist

@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

❌ Patch coverage is 97.72727% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.67%. Comparing base (a6e3492) to head (c33e7ae).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...rnal/storage/v2/cassandra/tracestore/to_dbmodel.go 96.87% 2 Missing and 2 partials ⚠️
...al/storage/v2/cassandra/tracestore/from_dbmodel.go 98.68% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7809      +/-   ##
==========================================
+ Coverage   95.47%   95.67%   +0.19%     
==========================================
  Files         307      307              
  Lines       15892    15799      -93     
==========================================
- Hits        15173    15115      -58     
+ Misses        564      543      -21     
+ Partials      155      141      -14     
Flag Coverage Δ
badger_v1 9.30% <0.00%> (+0.09%) ⬆️
badger_v2 1.95% <0.00%> (+0.01%) ⬆️
cassandra-4.x-v1-manual 13.75% <4.54%> (+0.13%) ⬆️
cassandra-4.x-v2-auto 1.94% <0.00%> (+0.01%) ⬆️
cassandra-4.x-v2-manual 1.94% <0.00%> (+0.01%) ⬆️
cassandra-5.x-v1-manual 13.75% <4.54%> (+0.13%) ⬆️
cassandra-5.x-v2-auto 1.94% <0.00%> (+0.01%) ⬆️
cassandra-5.x-v2-manual 1.94% <0.00%> (+0.01%) ⬆️
clickhouse 1.87% <0.00%> (+0.01%) ⬆️
elasticsearch-6.x-v1 17.76% <0.00%> (+0.17%) ⬆️
elasticsearch-7.x-v1 17.79% <0.00%> (+0.18%) ⬆️
elasticsearch-8.x-v1 17.95% <0.00%> (+0.18%) ⬆️
elasticsearch-8.x-v2 1.95% <0.00%> (+0.01%) ⬆️
elasticsearch-9.x-v2 1.95% <0.00%> (+0.01%) ⬆️
grpc_v1 8.95% <0.00%> (+0.09%) ⬆️
grpc_v2 1.95% <0.00%> (+0.01%) ⬆️
kafka-3.x-v2 1.95% <0.00%> (+0.01%) ⬆️
memory_v2 1.95% <0.00%> (+0.01%) ⬆️
opensearch-1.x-v1 17.84% <0.00%> (+0.18%) ⬆️
opensearch-2.x-v1 17.84% <0.00%> (+0.18%) ⬆️
opensearch-2.x-v2 1.95% <0.00%> (+0.01%) ⬆️
opensearch-3.x-v2 1.95% <0.00%> (+0.01%) ⬆️
query 1.95% <0.00%> (+0.01%) ⬆️
tailsampling-processor 0.56% <0.00%> (+<0.01%) ⬆️
unittests 94.29% <97.72%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Manik2708
Copy link
Contributor Author

working on code coverage

@yurishkuro
Copy link
Member

please resolve merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants