Add new binary artifact for gRPC storage integration testing #7807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@yurishkuro I’m planning to add documentation for the storage integration test binary next. Since this binary is intended to be used by third-party storage implementers (end users) rather than Jaeger contributors, would you prefer the documentation to live in the official Jaeger docs (e.g. under storage or deployment docs), or in a contributor-focused location like CONTRIBUTING.md? Happy to follow whatever direction makes the most sense. |
yurishkuro
reviewed
Dec 30, 2025
Member
|
we already have |
Author
|
@yurishkuro I have addressed all of the discussed ideas, let me know if this sits well with you |
yurishkuro
reviewed
Dec 30, 2025
yurishkuro
requested changes
Dec 30, 2025
yurishkuro
reviewed
Dec 30, 2025
yurishkuro
reviewed
Dec 30, 2025
Author
These are the tests on my PR that I didhalyee@Haylee:~/Harsh/Linux/jaeger$ make build-binaries-linux-amd64
GOOS=linux GOARCH=amd64 make _build-platform-binaries
make[1]: Entering directory '/home/halyee/Harsh/Linux/jaeger'
fatal: No names found, cannot describe anything.
🚧 building binary './cmd/jaeger' for linux-amd64
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -o ./cmd/jaeger/jaeger-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/internal/version.commitSHA=bd95bc672e82f5a407e72be44b10ad020825060c -X github.com/jaegertracing/jaeger/internal/version.latestVersion= -X github.com/jaegertracing/jaeger/internal/version.date=2025-12-30T23:07:39Z" ./cmd/jaeger
Checking version of built binary
{"gitCommit":"bd95bc672e82f5a407e72be44b10ad020825060c","gitVersion":"","buildDate":"2025-12-30T23:07:39Z"}
☑️ versions match: want=, have=
🚧 building binary './cmd/remote-storage' for linux-amd64
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -o ./cmd/remote-storage/remote-storage-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/internal/version.commitSHA=bd95bc672e82f5a407e72be44b10ad020825060c -X github.com/jaegertracing/jaeger/internal/version.latestVersion= -X github.com/jaegertracing/jaeger/internal/version.date=2025-12-30T23:07:39Z" ./cmd/remote-storage
go test -c ./internal/storage/integration \
-o ./cmd/remote-storage/jaeger-storage-integration-tester-linux-amd64
🚧 building binary '' for linux-amd64
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -o ./examples/hotrod/hotrod-linux-amd64 ./examples/hotrod/main.go
🚧 building binary 'tracegen' for linux-amd64
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -o ./cmd/tracegen/tracegen-linux-amd64 ./cmd/tracegen/
🚧 building binary 'anonymizer' for linux-amd64
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -o ./cmd/anonymizer/anonymizer-linux-amd64 ./cmd/anonymizer/
🚧 building binary 'esmapping-generator' for linux-amd64
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -o ./cmd/esmapping-generator/esmapping-generator-linux-amd64 ./cmd/esmapping-generator/
🚧 building binary 'es-index-cleaner' for linux-amd64
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -o ./cmd/es-index-cleaner/es-index-cleaner-linux-amd64 ./cmd/es-index-cleaner/
🚧 building binary 'es-rollover' for linux-amd64
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -o ./cmd/es-rollover/es-rollover-linux-amd64 ./cmd/es-rollover/
make _build-platform-binaries-debug GOOS=linux GOARCH=amd64 DEBUG_BINARY=1
make[2]: Entering directory '/home/halyee/Harsh/Linux/jaeger'
fatal: No names found, cannot describe anything.
🚧 building binary './cmd/jaeger' for linux-amd64
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -gcflags="all=-N -l" -o ./cmd/jaeger/jaeger-debug-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/internal/version.commitSHA=bd95bc672e82f5a407e72be44b10ad020825060c -X github.com/jaegertracing/jaeger/internal/version.latestVersion= -X github.com/jaegertracing/jaeger/internal/version.date=2025-12-30T23:07:39Z" ./cmd/jaeger
Checking version of built binary
{"gitCommit":"bd95bc672e82f5a407e72be44b10ad020825060c","gitVersion":"","buildDate":"2025-12-30T23:07:39Z"}
☑️ versions match: want=, have=
🚧 building binary './cmd/remote-storage' for linux-amd64
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -gcflags="all=-N -l" -o ./cmd/remote-storage/remote-storage-debug-linux-amd64 -ldflags "-X github.com/jaegertracing/jaeger/internal/version.commitSHA=bd95bc672e82f5a407e72be44b10ad020825060c -X github.com/jaegertracing/jaeger/internal/version.latestVersion= -X github.com/jaegertracing/jaeger/internal/version.date=2025-12-30T23:07:39Z" ./cmd/remote-storage
make[2]: Leaving directory '/home/halyee/Harsh/Linux/jaeger'
make[1]: Leaving directory '/home/halyee/Harsh/Linux/jaeger'Commands are in the terminal and the added binary in
|
yurishkuro
approved these changes
Dec 31, 2025
Member
|
All commits must be signed. See CONTRIBUTING.md
You also need to run scripts/build/package-deploy.sh and inspect the archives it creates |
yurishkuro
added
the
changelog:new-feature
yurishkuro
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7807 +/- ##
==========================================
+ Coverage 95.47% 95.51% +0.03%
==========================================
Files 307 307
Lines 15892 15892
==========================================
+ Hits 15173 15179 +6
+ Misses 564 560 -4
+ Partials 155 153 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Metrics Comparison SummaryTotal changes across all snapshots: 90 Detailed changes per snapshotsummary_metrics_snapshot_clickhouse📊 Metrics Diff SummaryTotal Changes: 90
🆕 Added Metrics
View diff sample+rpc_server_duration_milliseconds{le="+Inf",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_duration_milliseconds{le="0",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_duration_milliseconds{le="10",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_duration_milliseconds{le="100",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_duration_milliseconds{le="1000",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_duration_milliseconds{le="10000",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_duration_milliseconds{le="25",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
...View diff sample+rpc_server_request_size_bytes{le="+Inf",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_request_size_bytes{le="0",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_request_size_bytes{le="10",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_request_size_bytes{le="100",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_request_size_bytes{le="1000",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_request_size_bytes{le="10000",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_request_size_bytes{le="25",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
...View diff sample+rpc_server_requests_per_rpc{le="+Inf",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_requests_per_rpc{le="0",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_requests_per_rpc{le="10",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_requests_per_rpc{le="100",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_requests_per_rpc{le="1000",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_requests_per_rpc{le="10000",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_requests_per_rpc{le="25",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
...View diff sample+rpc_server_response_size_bytes{le="+Inf",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_response_size_bytes{le="0",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_response_size_bytes{le="10",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_response_size_bytes{le="100",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_response_size_bytes{le="1000",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_response_size_bytes{le="10000",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_response_size_bytes{le="25",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
...View diff sample+rpc_server_responses_per_rpc{le="+Inf",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_responses_per_rpc{le="0",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_responses_per_rpc{le="10",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_responses_per_rpc{le="100",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_responses_per_rpc{le="1000",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_responses_per_rpc{le="10000",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
+rpc_server_responses_per_rpc{le="25",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_schema_url="https://opentelemetry.io/schemas/1.37.0",otel_scope_version="0.64.0",rpc_grpc_status_code="0",rpc_method="FindTraces",rpc_service="jaeger.api_v3.QueryService",rpc_system="grpc"}
... |
Author
|
okay Actually I used |
ThatDeparted2061
force-pushed
the
storage-integration-tests-binary
branch
from
446ab2f to
91a78ce
Compare
Author
done |
Member
|
The branch is messed up. You either do |
Author
|
I am sorry for the delay, i ll look into it |
Signed-off-by: ThatDeparted2061 <[email protected]>
Signed-off-by: ThatDeparted2061 <[email protected]>
Signed-off-by: ThatDeparted2061 <[email protected]>
Signed-off-by: ThatDeparted2061 <[email protected]>
…release Signed-off-by: ThatDeparted2061 <[email protected]>
Signed-off-by: ThatDeparted2061 <[email protected]>
… test binary Signed-off-by: ThatDeparted2061 <[email protected]>
Part of jaegertracing#6321 * remove `internal/storage/v1/grpc/*` * update `remote-storage` to no longer provide v1 gRPC storage API --------- Signed-off-by: Yuri Shkuro <[email protected]> Signed-off-by: ThatDeparted2061 <[email protected]>
…egertracing#7798) Signed-off-by: ThatDeparted2061 <[email protected]>
…on-tester Signed-off-by: ThatDeparted2061 <[email protected]>
…ster Signed-off-by: ThatDeparted2061 <[email protected]>
ThatDeparted2061
force-pushed
the
storage-integration-tests-binary
branch
from
91a78ce to
3d32b46
Compare
Author
|
@yurishkuro I am facing this conflict |
Author
|
@yurishkuro Can we have some idea here ?? |
Member
|
@ThatDeparted2061 your change has nothing to do with clickhouse so make sure it's not introducing any unrelated changes during merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
go test -cworkflow.build-all-platformsandpackage-deploy.sh) without introducing custom CI logic.jaeger-toolsrelease artifacts for all supported platforms.go testbehavior and does not change the integration test logic.How was this change tested?
build-binaries-<platform>successfully produces the storage integration test binary locally.jaeger-tools-<version>-<platform>bypackage-deploy.sh.Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test