-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Replaced bitnami kafka image with Apache Kafka #7762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,35 +1,7 @@ | ||
| services: | ||
| zookeeper: | ||
| image: bitnami/zookeeper@sha256:95655e9d5653bd132b07eb3aaed2ba49bb5b175853df20e82fe1fcb0d4a28579 | ||
| ports: | ||
| - 2181:2181 | ||
| environment: | ||
| - ALLOW_ANONYMOUS_LOGIN=yes | ||
| kafka: | ||
| image: index.docker.io/bitnami/[email protected] | ||
| ports: | ||
| - '9092:9092' | ||
| environment: | ||
| - KAFKA_BROKER_ID=1 | ||
| - KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR=1 | ||
| - KAFKA_CFG_ZOOKEEPER_CONNECT=zookeeper:2181 | ||
| - ALLOW_PLAINTEXT_LISTENER=yes | ||
| - KAFKA_LISTENERS=INTERNAL://0.0.0.0:9092,OUTSIDE://0.0.0.0:9094 | ||
| - KAFKA_ADVERTISED_LISTENERS=INTERNAL://kafka:9092,OUTSIDE://localhost:9094 | ||
| - KAFKA_LISTENER_SECURITY_PROTOCOL_MAP=INTERNAL:PLAINTEXT,OUTSIDE:PLAINTEXT | ||
| - KAFKA_INTER_BROKER_LISTENER_NAME=INTERNAL | ||
| restart: always | ||
| depends_on: | ||
| - zookeeper | ||
| links: | ||
| - zookeeper | ||
| healthcheck: | ||
| test: ["CMD-SHELL", "kafka-topics.sh --list --bootstrap-server 127.0.0.1:9092"] | ||
| interval: 5s | ||
| timeout: 5s | ||
| retries: 3 | ||
| start_period: 5s | ||
| include: | ||
| - path: v3/docker-compose.yml | ||
|
|
||
| services: | ||
| jaeger-remote-storage: | ||
| image: cr.jaegertracing.io/jaegertracing/jaeger-remote-storage@sha256:e78c6093ac38f7cdccf0877750bb21f2cbcc08c2fd3e578966b5796a31f26643 | ||
| ports: | ||
|
|
@@ -49,13 +21,14 @@ services: | |
| command: | ||
| - "--config=/etc/jaeger/config.yaml" | ||
| environment: | ||
| - KAFKA_BROKER=kafka:9092 | ||
| - KAFKA_TOPIC=jaeger-spans | ||
| - KAFKA_ENCODING=otlp_proto | ||
| ports: | ||
| - 4318:4318 | ||
| - 14250:14250 | ||
| healthcheck: | ||
| test: ["CMD-SHELL", "wget --no-verbose --tries=1 --spider http://localhost:14269/ || exit 1"] | ||
| test: ["CMD-SHELL", "wget --no-verbose --tries=1 --spider http://localhost:13133/status || exit 1"] | ||
| interval: 5s | ||
| timeout: 5s | ||
| retries: 3 | ||
|
|
@@ -72,10 +45,11 @@ services: | |
| command: | ||
| - "--config=/etc/jaeger/config.yaml" | ||
| environment: | ||
| - KAFKA_BROKER=kafka:9092 | ||
| - KAFKA_TOPIC=jaeger-spans | ||
| - KAFKA_ENCODING=otlp_proto | ||
| healthcheck: | ||
| test: ["CMD-SHELL", "wget --no-verbose --tries=1 --spider http://localhost:14133/ || exit 1"] | ||
| test: ["CMD-SHELL", "wget --no-verbose --tries=1 --spider http://localhost:14133/status || exit 1"] | ||
| interval: 5s | ||
| timeout: 5s | ||
| retries: 3 | ||
|
|
@@ -104,7 +78,7 @@ services: | |
| - "16687" | ||
| restart: on-failure | ||
| healthcheck: | ||
| test: ["CMD-SHELL", "wget --no-verbose --tries=1 --spider http://localhost:16687/ || exit 1"] | ||
| test: ["CMD-SHELL", "wget --no-verbose --tries=1 --spider http://localhost:13133/status || exit 1"] | ||
| interval: 5s | ||
| timeout: 5s | ||
| retries: 3 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,53 +1,34 @@ | ||
| version: "3" | ||
| services: | ||
| kafka: | ||
| image: bitnami/kafka:3.9.0@sha256:55df55bfc7ed5980447387620afa3498eab3985a4d8c731013d82b3fa8b43bff | ||
| user: "0:0" # Run as root to avoid permission issues | ||
| image: apache/kafka:3.9.0 | ||
| hostname: kafka | ||
| ports: | ||
| - "9092:9092" | ||
| - "9093:9093" | ||
| - "9094:9094" | ||
| - "9095:9095" | ||
| volumes: | ||
| - ../../../internal/config/tlscfg/testdata:/bitnami/kafka/config/certs | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. so if we are not mapping certs, do we still need all the functionality in @Parship12 what was the intent of introducing those in #7395 ? It seems our Kafka exporter config is pretty vanilla without any authentication
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, that's correct - those ports were added in #7395 to support testing diff authentication methods. However, after looking at the actual tests, i noticed that: Current situation is the infrastructure exists (ports BUT the actual integration tests in The code fix from #7395 (supporting TLS with different auth methods) works correctly, but the test infrastructure to verify it was never actually used. Should I raise a PR to simplify it? (remove unused ports
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The ports are already being removed / simplified in this PR. I think it's ok for us to not test auth permutations, since we're just using the upstream exporter/receiver. |
||
| - kafka-data:/bitnami | ||
| - kafka-data:/var/lib/kafka/data | ||
| environment: | ||
| # KRaft settings | ||
| - KAFKA_CFG_NODE_ID=1 | ||
| - KAFKA_CFG_PROCESS_ROLES=controller,broker | ||
| - KAFKA_CFG_CONTROLLER_QUORUM_VOTERS=1@localhost:9096 | ||
| # Listeners | ||
| - KAFKA_CFG_LISTENERS=PLAINTEXT://:9092,CONTROLLER://:9096,SASL_SSL://:9093,SASL_PLAINTEXT://:9095 | ||
| - KAFKA_CFG_ADVERTISED_LISTENERS=PLAINTEXT://127.0.0.1:9092,SASL_SSL://127.0.0.1:9093,SASL_PLAINTEXT://127.0.0.1:9095 | ||
| - KAFKA_CFG_LISTENER_SECURITY_PROTOCOL_MAP=CONTROLLER:PLAINTEXT,PLAINTEXT:PLAINTEXT,SASL_SSL:SASL_SSL,SASL_PLAINTEXT:SASL_PLAINTEXT | ||
| - KAFKA_CFG_CONTROLLER_LISTENER_NAMES=CONTROLLER | ||
| - KAFKA_CFG_INTER_BROKER_LISTENER_NAME=PLAINTEXT | ||
| # SASL Configuration | ||
| - KAFKA_CFG_SASL_ENABLED_MECHANISMS=PLAIN | ||
| - KAFKA_CLIENT_USERS=admin | ||
| - KAFKA_CLIENT_PASSWORDS=admin-secret | ||
| # SSL Configuration | ||
| - KAFKA_TLS_TYPE=JKS | ||
| - KAFKA_CFG_SSL_KEYSTORE_LOCATION=/bitnami/kafka/config/certs/kafka.keystore.jks | ||
| - KAFKA_CFG_SSL_KEYSTORE_PASSWORD=kafkapass123 | ||
| - KAFKA_CFG_SSL_KEY_PASSWORD=kafkapass123 | ||
| - KAFKA_CFG_SSL_TRUSTSTORE_LOCATION=/bitnami/kafka/config/certs/kafka.truststore.jks | ||
| - KAFKA_CFG_SSL_TRUSTSTORE_PASSWORD=kafkapass123 | ||
| # Allow plaintext listener for development | ||
| - ALLOW_PLAINTEXT_LISTENER=yes | ||
| # Debug mode for more verbose logs | ||
| - BITNAMI_DEBUG=true | ||
| # KRaft settings (no ZooKeeper needed) | ||
| KAFKA_NODE_ID: 1 | ||
| KAFKA_PROCESS_ROLES: broker,controller | ||
| KAFKA_CONTROLLER_QUORUM_VOTERS: 1@kafka:9094 | ||
|
|
||
| KAFKA_LISTENERS: PLAINTEXT://:9092,CONTROLLER://:9094 | ||
| KAFKA_ADVERTISED_LISTENERS: PLAINTEXT://localhost:9092 | ||
| KAFKA_LISTENER_SECURITY_PROTOCOL_MAP: CONTROLLER:PLAINTEXT,PLAINTEXT:PLAINTEXT | ||
| KAFKA_CONTROLLER_LISTENER_NAMES: CONTROLLER | ||
| KAFKA_INTER_BROKER_LISTENER_NAME: PLAINTEXT | ||
| # Additional settings | ||
| - KAFKA_CFG_AUTO_CREATE_TOPICS_ENABLE=true | ||
| # Force skip KRaft initialization if already done | ||
| - KAFKA_SKIP_KRAFT_STORAGE_INITIALIZATION=yes | ||
| # KRaft cluster ID | ||
| - KAFKA_KRAFT_CLUSTER_ID=MkU3OEVBNTcwNTJENDM2Qg | ||
| KAFKA_AUTO_CREATE_TOPICS_ENABLE: "true" | ||
| KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR: 1 | ||
| KAFKA_TRANSACTION_STATE_LOG_REPLICATION_FACTOR: 1 | ||
| KAFKA_TRANSACTION_STATE_LOG_MIN_ISR: 1 | ||
| # CLUSTER_ID for KRaft | ||
| CLUSTER_ID: test_kafka_cluster_id | ||
| healthcheck: | ||
| test: | ||
| [ | ||
| "CMD-SHELL", | ||
| "kafka-topics.sh --list --bootstrap-server localhost:9092", | ||
| "/opt/kafka/bin/kafka-topics.sh --list --bootstrap-server localhost:9092", | ||
| ] | ||
| interval: 30s | ||
| timeout: 10s | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.