Skip to content

Conversation

@neoandmatrix
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • This PR introduces the changes in scripts to also include count of exclusions in metrics if any.

How was this change tested?

image image

Checklist

@neoandmatrix neoandmatrix requested a review from a team as a code owner December 18, 2025 14:37
@dosubot dosubot bot added the enhancement label Dec 18, 2025
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.51%. Comparing base (7193099) to head (ef9f4fa).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7756      +/-   ##
==========================================
- Coverage   95.53%   95.51%   -0.03%     
==========================================
  Files         307      307              
  Lines       15911    15911              
==========================================
- Hits        15201    15197       -4     
- Misses        558      561       +3     
- Partials      152      153       +1     
Flag Coverage Δ
badger_v1 9.18% <ø> (ø)
badger_v2 1.93% <ø> (ø)
cassandra-4.x-v1-manual 13.58% <ø> (ø)
cassandra-4.x-v2-auto 1.92% <ø> (ø)
cassandra-4.x-v2-manual 1.92% <ø> (ø)
cassandra-5.x-v1-manual 13.58% <ø> (ø)
cassandra-5.x-v2-auto 1.92% <ø> (ø)
cassandra-5.x-v2-manual 1.92% <ø> (ø)
clickhouse 1.97% <ø> (ø)
elasticsearch-6.x-v1 17.54% <ø> (ø)
elasticsearch-7.x-v1 17.57% <ø> (ø)
elasticsearch-8.x-v1 17.73% <ø> (ø)
elasticsearch-8.x-v2 1.93% <ø> (ø)
elasticsearch-9.x-v2 1.93% <ø> (ø)
grpc_v1 8.84% <ø> (ø)
grpc_v2 1.93% <ø> (ø)
kafka-3.x-v2 1.93% <ø> (ø)
memory_v2 1.93% <ø> (ø)
opensearch-1.x-v1 17.62% <ø> (ø)
opensearch-2.x-v1 17.62% <ø> (ø)
opensearch-2.x-v2 1.93% <ø> (ø)
opensearch-3.x-v2 1.93% <ø> (ø)
query 1.93% <ø> (ø)
tailsampling-processor 0.55% <ø> (ø)
unittests 94.14% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Metrics Comparison Summary

Total changes across all snapshots: 0

Detailed changes per snapshot

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

Total Changes: 0

  • 🆕 Added: 0 metrics
  • ❌ Removed: 0 metrics
  • 🔄 Modified: 0 metrics

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

Total Changes: 0

  • 🆕 Added: 0 metrics
  • ❌ Removed: 0 metrics
  • 🔄 Modified: 0 metrics

➡️ View full metrics file

@neoandmatrix neoandmatrix marked this pull request as draft December 18, 2025 15:10
@neoandmatrix neoandmatrix marked this pull request as ready for review December 19, 2025 06:44
@neoandmatrix neoandmatrix marked this pull request as draft December 19, 2025 06:57
@neoandmatrix neoandmatrix marked this pull request as ready for review December 19, 2025 12:07
@neoandmatrix
Copy link
Contributor Author

Hi @yurishkuro , I have modified the scripts to post the exclusion count. Currently I have integrated them with the format which we were already using. I tested all the scripts in the order which they are run in the CI and they are working fine in the local system. I got the output as below screenshot
image
from scripts/e2e/metrics_summary.sh which is used in CI https://github.com/jaegertracing/jaeger/actions/runs/20369773001/job/58533326928 to generate the summary that is to be posted.
But when I looked at the output of the run it was different from what i am getting as the exclusions are not counted. I am not sure why it is happening as i also inspected the diff artifacts from the E2E test run generated as output of the comparison in https://github.com/jaegertracing/jaeger/actions/runs/20369549009. The diffs are what i am getting while testing locally but the summary is mismatched. I am trying to investigate this.

Can you please have a look and suggest if i am missing something and also if i should change the comment format for exclusions?
Thanks.

@yurishkuro yurishkuro changed the title chore: exclusion count of metrics added. [chore/CI] Add excluded metrics count Jan 7, 2026
@yurishkuro yurishkuro added changelog:ci Change related to continuous integration / testing and removed changelog:bugfix-or-minor-feature labels Jan 7, 2026
@yurishkuro yurishkuro merged commit baac057 into jaegertracing:main Jan 7, 2026
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:ci Change related to continuous integration / testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants