fix inccorect setting in pixel shader template #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PS_TEXTUREMODES_DOT_RFLCT_DIFF(ts) should be normal 2 not normal 3 fixes light reflections in halo (floor )
|
though it need another fix to be visible currently, here is an after shot with a work around for vertexshader selection showing the results of the pixel shader template change the white light reflection highlights on the floor are not present without fix... screen shot is subtle, in movement though it is much more prominent |
PatrickvL
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PS_TEXTUREMODES_DOT_RFLCT_DIFF(ts) should be normal2 not normal3 fixes light reflections in halo (floor )